Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

!chore: Remove support for MXJob #1953

Closed
wants to merge 8 commits into from
Closed

!chore: Remove support for MXJob #1953

wants to merge 8 commits into from

Conversation

terrytangyuan
Copy link
Member

Unfortunately, Apache MXNet has been archived. This PR removes MXJob support.

Signed-off-by: terrytangyuan <[email protected]>
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: terrytangyuan <[email protected]>
Signed-off-by: terrytangyuan <[email protected]>
Copy link

Pull Request Test Coverage Report for Build 7023065747

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.9%) to 41.988%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 6 80.67%
Totals Coverage Status
Change from base Build 7007158786: -0.9%
Covered Lines: 3346
Relevant Lines: 7969

💛 - Coveralls

Signed-off-by: terrytangyuan <[email protected]>
@coveralls
Copy link

coveralls commented Nov 28, 2023

Pull Request Test Coverage Report for Build 7023661984

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.9%) to 41.975%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob.go 1 91.06%
Totals Coverage Status
Change from base Build 7007158786: -0.9%
Covered Lines: 3345
Relevant Lines: 7969

💛 - Coveralls

Signed-off-by: terrytangyuan <[email protected]>
Signed-off-by: terrytangyuan <[email protected]>
Signed-off-by: terrytangyuan <[email protected]>
Signed-off-by: terrytangyuan <[email protected]>
@terrytangyuan terrytangyuan changed the title chore: Remove support for MXJob !chore: Remove support for MXJob Nov 29, 2023
@terrytangyuan
Copy link
Member Author

This would be a breaking change but I think it's relatively safe given how few people are using MXNet these days. cc @kubeflow/wg-training-leads

@andreyvelich
Copy link
Member

Thank you for creating this @terrytangyuan.
That is sad to hear that Apache MXNet has been archived, it has a lot of potential.

I think, we still use MXNet for various things. E.g. this Trial image is the most popular in Katib: https://github.com/kubeflow/katib/tree/master/examples/v1beta1/trial-images/mxnet-mnist

Let's discuss it in one of our upcoming WG meetings on how to inform Kubeflow users about it.
/hold

@terrytangyuan
Copy link
Member Author

Any concerns of removing this? I don't think we want to continue supporting it.

@andreyvelich
Copy link
Member

Related: #1996.
We should merge this PR once we make Training Operator 1.9 release.

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@tenzen-y
Copy link
Member

/remove-lifecycle stale

@terrytangyuan
Copy link
Member Author

Does anyone want to pick this up?

@terrytangyuan
Copy link
Member Author

I don't think I'll have time to complete this. If you are interested in contributing, feel free to start a new PR.

@tariq-hasan
Copy link
Contributor

I can pick up this one.

@andreyvelich andreyvelich deleted the rm-mxnet branch June 24, 2024 23:40
@andreyvelich
Copy link
Member

Thank you @tariq-hasan!
Please feel free to submit another PR to remove Apache MXNet support, and we can merge it after Kubeflow Training 1.8 release.

@tariq-hasan
Copy link
Contributor

Sound good.

@terrytangyuan
Copy link
Member Author

Great. Thanks!

@tariq-hasan tariq-hasan mentioned this pull request Jun 25, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants