-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a more up to date example for tensorflow #1885
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kannon92 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -12,7 +12,8 @@ spec: | |||
spec: | |||
containers: | |||
- name: tensorflow | |||
image: kubeflow/tf-mnist-with-summaries:latest | |||
image: docker.io/kubeflowkatib/tf-mnist-with-summaries:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is the source Dockerfile for this image?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we should remove https://github.com/kubeflow/training-operator/tree/855e0960668b34992ba4e1fd5914a08a3362cfb1/examples/tensorflow/mnist_with_summaries as well. @terrytangyuan WDYT? |
Perhaps add a link in the comment? We can keep the existing Dockerfiles if they still work (warnings are fine). |
SGTM |
ea42470
to
333601c
Compare
I was not entirely sure what you meant by this. I added a comment to my example. I found the warnings to be very scary for a new user. Using python 2.7 and a series of warnings around deprecated features, I was worried that it would break if I wanted to use this as an example. It would be nice to have an up-to-date image in the examples. |
Pull Request Test Coverage Report for Build 5836921251
💛 - Coveralls |
Ref: #1884 (comment) |
As @johnugeorge mentions, I think we want to go a different route. Rather than changing this image, the tensorflow example image should just be updated to use latest tensorflow. |
What this PR does / why we need it:
#1884 explains the reason.
I tried to run the example and I got a lot of warnings. @tenzen-y mentioned that this image is maintained in other examples.
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...
format, will close the issue(s) when PR gets merged):Fixes #1884
Checklist: