Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a more up to date example for tensorflow #1885

Closed
wants to merge 1 commit into from

Conversation

kannon92
Copy link

What this PR does / why we need it:
#1884 explains the reason.

I tried to run the example and I got a lot of warnings. @tenzen-y mentioned that this image is maintained in other examples.
Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #1884

Checklist:

  • Docs included if any changes are user facing

@google-cla
Copy link

google-cla bot commented Aug 11, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kannon92
Once this PR has been reviewed and has the lgtm label, please assign jeffwan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -12,7 +12,8 @@ spec:
spec:
containers:
- name: tensorflow
image: kubeflow/tf-mnist-with-summaries:latest
image: docker.io/kubeflowkatib/tf-mnist-with-summaries:latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the source Dockerfile for this image?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tenzen-y
Copy link
Member

@terrytangyuan
Copy link
Member

Perhaps add a link in the comment? We can keep the existing Dockerfiles if they still work (warnings are fine).

@tenzen-y
Copy link
Member

Perhaps add a link in the comment? We can keep the existing Dockerfiles if they still work (warnings are fine).

SGTM

@kannon92
Copy link
Author

Perhaps add a link in the comment? We can keep the existing Dockerfiles if they still work (warnings are fine).

I was not entirely sure what you meant by this. I added a comment to my example.

I found the warnings to be very scary for a new user. Using python 2.7 and a series of warnings around deprecated features, I was worried that it would break if I wanted to use this as an example.

It would be nice to have an up-to-date image in the examples.

@coveralls
Copy link

coveralls commented Aug 12, 2023

Pull Request Test Coverage Report for Build 5836921251

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.06%) to 42.777%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob.go 1 91.06%
pkg/controller.v1/mpi/mpijob_controller.go 2 80.5%
pkg/controller.v1/pytorch/pytorchjob_controller.go 4 67.42%
Totals Coverage Status
Change from base Build 5772492904: -0.06%
Covered Lines: 3737
Relevant Lines: 8736

💛 - Coveralls

@johnugeorge
Copy link
Member

Ref: #1884 (comment)

@kannon92
Copy link
Author

As @johnugeorge mentions, I think we want to go a different route.

Rather than changing this image, the tensorflow example image should just be updated to use latest tensorflow.

@kannon92 kannon92 closed this Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tensorflow example image has a lot of warnings and python 2.7.
5 participants