Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sdk to v1.7.0rc0 #1882

Merged
merged 7 commits into from
Aug 7, 2023
Merged

Conversation

johnugeorge
Copy link
Member

Update SDK version to v1.7.0 RC0 version

/assign @tenzen-y

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

coveralls commented Aug 7, 2023

Pull Request Test Coverage Report for Build 5782111700

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 42.754%

Totals Coverage Status
Change from base Build 5781997841: 0.0%
Covered Lines: 3735
Relevant Lines: 8736

💛 - Coveralls

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, LGTM.
/lgtm

@@ -24,7 +24,7 @@ SWAGGER_JAR_URL="https://repo1.maven.org/maven2/org/openapitools/openapi-generat
SWAGGER_CODEGEN_JAR="${repo_root}/hack/python-sdk/openapi-generator-cli.jar"
SWAGGER_CODEGEN_CONF="${repo_root}/hack/python-sdk/swagger_config.json"
SDK_OUTPUT_PATH="${repo_root}/sdk/python"
VERSION=1.5.0
VERSION=1.7.0rc0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhm, the master branch is still 1.5.0 :(
@johnugeorge Can you submit a PR to the master branch to update the SDK version to v1.6.0?

@google-oss-prow google-oss-prow bot added the lgtm label Aug 7, 2023
@google-oss-prow google-oss-prow bot merged commit 434cef7 into kubeflow:v1.7-branch Aug 7, 2023
24 checks passed
google-oss-prow bot pushed a commit that referenced this pull request Nov 1, 2023
* Update latest training operator images in v1.7 branch (#1881)

* Removing dead code

* Update monitoring guide

* Update latest training operator image

* Update sdk to v1.7.0rc0 (#1882)

* Removing dead code

* Update monitoring guide

* Update latest training operator image

* Update SDK version to v1.7.0rc0

* Update sdk to v1.7.0 (#1939)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants