-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sdk to v1.7.0rc0 #1882
Update sdk to v1.7.0rc0 #1882
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Pull Request Test Coverage Report for Build 5782111700
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, LGTM.
/lgtm
@@ -24,7 +24,7 @@ SWAGGER_JAR_URL="https://repo1.maven.org/maven2/org/openapitools/openapi-generat | |||
SWAGGER_CODEGEN_JAR="${repo_root}/hack/python-sdk/openapi-generator-cli.jar" | |||
SWAGGER_CODEGEN_CONF="${repo_root}/hack/python-sdk/swagger_config.json" | |||
SDK_OUTPUT_PATH="${repo_root}/sdk/python" | |||
VERSION=1.5.0 | |||
VERSION=1.7.0rc0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uhm, the master branch is still 1.5.0 :(
@johnugeorge Can you submit a PR to the master branch to update the SDK version to v1.6.0?
* Update latest training operator images in v1.7 branch (#1881) * Removing dead code * Update monitoring guide * Update latest training operator image * Update sdk to v1.7.0rc0 (#1882) * Removing dead code * Update monitoring guide * Update latest training operator image * Update SDK version to v1.7.0rc0 * Update sdk to v1.7.0 (#1939)
Update SDK version to v1.7.0 RC0 version
/assign @tenzen-y