Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Prometheus metrics in doc #1880

Merged
merged 3 commits into from
Aug 5, 2023
Merged

Conversation

johnugeorge
Copy link
Member

Update Prometheus metric names in doc. These have to be moved to Kubeflow/website separately.

Fixes: #1805

/assign @tenzen-y

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Aug 5, 2023
@coveralls
Copy link

coveralls commented Aug 5, 2023

Pull Request Test Coverage Report for Build 5772288736

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 42.754%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob.go 1 91.06%
Totals Coverage Status
Change from base Build 5750051689: -0.01%
Covered Lines: 3735
Relevant Lines: 8736

💛 - Coveralls

@google-oss-prow google-oss-prow bot merged commit 855e096 into kubeflow:master Aug 5, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated GPU monitoring info in README
3 participants