Skip to content

Commit

Permalink
make 'setup-storage-initializer-and-trainer' executable
Browse files Browse the repository at this point in the history
Signed-off-by: helenxie-bit <[email protected]>
  • Loading branch information
helenxie-bit committed Sep 21, 2024
1 parent 45eb7e0 commit f217794
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/e2e-test-train-api.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:
GANG_SCHEDULER_NAME: "none"
KUBERNETES_VERSION: ${{ matrix.kubernetes-version }}

- name: Build and load storage initializer and trainer
- name: Build storage initializer and trainer
run: |
./scripts/gha/setup-storage-initializer-and-trainer.sh
env:
Expand Down
Empty file modified scripts/gha/setup-storage-initializer-and-trainer.sh
100644 → 100755
Empty file.
14 changes: 7 additions & 7 deletions sdk/python/kubeflow/training/api/training_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -258,9 +258,9 @@ def train(
],
volume_mounts=[constants.STORAGE_INITIALIZER_VOLUME_MOUNT],
)
base_image1=os.getenv(
"STORAGE_INITIALIZER_IMAGE", constants.STORAGE_INITIALIZER_IMAGE_DEFAULT
)
base_image1 = os.getenv(
"STORAGE_INITIALIZER_IMAGE", constants.STORAGE_INITIALIZER_IMAGE_DEFAULT
)
print("base_image1: " + base_image1)

# create app container spec
Expand Down Expand Up @@ -291,10 +291,10 @@ def train(
volume_mounts=[constants.STORAGE_INITIALIZER_VOLUME_MOUNT],
resources=resources_per_worker,
)
base_image2=os.getenv(
"TRAINER_TRANSFORMER_IMAGE_DEFAULT",
constants.TRAINER_TRANSFORMER_IMAGE_DEFAULT,
)
base_image2 = os.getenv(
"TRAINER_TRANSFORMER_IMAGE_DEFAULT",
constants.TRAINER_TRANSFORMER_IMAGE_DEFAULT,
)
print("base_image2: " + base_image2)

storage_initializer_volume = models.V1Volume(
Expand Down

0 comments on commit f217794

Please sign in to comment.