Skip to content

Commit

Permalink
Upgrade Go version to v1.20 (#1873)
Browse files Browse the repository at this point in the history
Signed-off-by: Yuki Iwai <[email protected]>
  • Loading branch information
tenzen-y committed Aug 1, 2023
1 parent 886698d commit de7c73e
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,10 @@ vet: ## Run go vet against code.
GOLANGCI_LINT=$(shell which golangci-lint)
golangci-lint:
ifeq ($(GOLANGCI_LINT),)
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(shell go env GOPATH)/bin v1.50.1
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(shell go env GOPATH)/bin v1.53.3
$(info golangci-lint has been installed)
endif
golangci-lint run --timeout 5m --go 1.19 ./...
golangci-lint run --timeout 5m --go 1.20 ./...

ENVTEST_K8S_VERSION ?= 1.27
HAS_SETUP_ENVTEST := $(shell command -v setup-envtest;)
Expand Down
2 changes: 1 addition & 1 deletion build/images/training-operator/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Build the manager binary
FROM golang:1.19 as builder
FROM golang:1.20 as builder

WORKDIR /workspace
# Copy the Go Modules manifests
Expand Down
2 changes: 1 addition & 1 deletion docs/development/developer_guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Kubeflow Training Operator is currently at v1.

## Requirements

- [Go](https://golang.org/) (1.17 or later)
- [Go](https://golang.org/) (1.20 or later)

## Building the operator

Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/kubeflow/training-operator

go 1.19
go 1.20

require (
github.com/go-logr/logr v1.2.4
Expand Down
2 changes: 1 addition & 1 deletion hack/swagger/go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/kubeflow/training-operator/hack/swagger

go 1.19
go 1.20

require (
github.com/kubeflow/training-operator v0.0.0-00010101000000-000000000000
Expand Down

0 comments on commit de7c73e

Please sign in to comment.