-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add go mod vendor check to integration test #1198
Add go mod vendor check to integration test #1198
Conversation
Signed-off-by: Yi Chen <[email protected]>
d342be2
to
a591984
Compare
/assign @cheyang |
run: | | ||
go mod vendor | ||
if ! git diff --quiet; then | ||
echo "Please run 'go mod vendor' to make vendored copy of dependencies" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go mod tidy && go mod vendor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cheyang There already is a step for checking go mod tidy
, see:
arena/.github/workflows/integration.yaml
Lines 30 to 36 in 29b2d6d
- name: Run go mod tidy | |
run: | | |
go mod tidy | |
if ! git diff --quiet; then | |
echo "Please run 'go mod tidy' to add missing and remove unused dependencies" | |
exit 1 | |
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Purpose of this PR
Proposed changes:
Change Category
Rationale