Fix several minimal bugs (#107)

* disable GPU for PS * fix the bugs of sedding yaml * revert the change
kubeflow · Jan 18, 2019 · 7cb79fe · 7cb79fe
1 parent 5826ff9
commit 7cb79fe
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/charts/tfjob/CHANGELOG.md b/charts/tfjob/CHANGELOG.md
@@ -61,4 +61,4 @@
 
 ### 0.15.0
 
-* Fix hostnetwork issue which is introduced by ENI
+* Fix hostnetwork issue which is introduced by ENI
diff --git a/cmd/arena/commands/trainer_tensorflow.go b/cmd/arena/commands/trainer_tensorflow.go
@@ -453,7 +453,7 @@ func hasCondition(status tfv1alpha2.TFJobStatus, condType tfv1alpha2.TFJobCondit
 }
 
 func checkStatus(status tfv1alpha2.TFJobStatus) tfv1alpha2.TFJobConditionType {
-	t := tfv1alpha2.TFJobConditionType("Unknown")
+	t := tfv1alpha2.TFJobConditionType("Pending")
 	for _, condition := range status.Conditions {
 		if condition.Status == v1.ConditionTrue {
 			t = condition.Type

diff --git a/docs/userguide/9-top-job-gpu-metric.md b/docs/userguide/9-top-job-gpu-metric.md
@@ -12,7 +12,7 @@ kubectl apply -f kubernetes-artifacts/prometheus/prometheus.yaml
 
 ```
 # change gpu export nodeSelector to aliyun label
-sed 's|accelerator/nvidia_gpu|aliyun.accelerator/nvidia_count|g' kubernetes-artifacts/prometheus/gpu-expoter.yaml
+sed -i 's|accelerator/nvidia_gpu|aliyun.accelerator/nvidia_count|g' kubernetes-artifacts/prometheus/gpu-expoter.yaml
 ```
 
 * If your cluster is not ACK cluster, you need to label your GPU node:

diff --git a/run_arena.sh b/run_arena.sh
@@ -47,7 +47,7 @@ fi
 
 if [ "$usePrometheus" == "true" ]; then
     if [ "$platform" == "ack" ]; then
-        sed 's|accelerator/nvidia_gpu|aliyun.accelerator/nvidia_count|g' /root/kubernetes-artifacts/prometheus/gpu-expoter.yaml
+        sed -i 's|accelerator/nvidia_gpu|aliyun.accelerator/nvidia_count|g' /root/kubernetes-artifacts/prometheus/gpu-expoter.yaml
     fi
 	if ! kubectl get serviceaccount --all-namespaces | grep prometheus; then
 	   kubectl apply -f /root/kubernetes-artifacts/prometheus/gpu-expoter.yaml