Fix: unable to set cleanPodPolicy to All when submitting TFJob (#1191)

Signed-off-by: Yi Chen <[email protected]>
kubeflow · Nov 7, 2024 · 46a795e · 46a795e
1 parent 76ca059
commit 46a795e
Showing 1 changed file with 4 additions and 10 deletions.
diff --git a/charts/tfjob/templates/tfjob.yaml b/charts/tfjob/templates/tfjob.yaml
@@ -1,7 +1,6 @@
 {{- $gpuCount := .Values.gpuCount -}}
 {{- $psGpuCount := .Values.psGPU -}}
 {{- $syncMode := .Values.syncMode -}}
-{{- $cleanPodPolicy := .Values.cleanPodPolicy -}}
 {{- $dataDirs := .Values.dataDirs -}}
 {{- $tfNodeSelectors :=.Values.tfNodeSelectors -}}
 apiVersion: "kubeflow.org/v1"
@@ -24,8 +23,8 @@ metadata:
 spec:
 {{- if .Values.trainingOperatorCRD }}
   runPolicy:
-    {{- if .Values.cleanPodPolicy }}
-    cleanPodPolicy: {{ .Values.cleanPodPolicy }}
+    {{- with .Values.cleanPodPolicy }}
+    cleanPodPolicy: {{ . }}
     {{- end }}
     {{- if .Values.activeDeadlineSeconds }}
     activeDeadlineSeconds: {{ .Values.activeDeadlineSeconds }}
@@ -34,13 +33,8 @@ spec:
     ttlSecondsAfterFinished: {{ .Values.ttlSecondsAfterFinished }}
     {{- end }}
 {{- else }}
-  {{- if .Values.cleanPodPolicy }}
-  {{- if eq "None" $cleanPodPolicy }}
-  cleanPodPolicy: None
-  {{- end }}
-  {{- if eq "Running" $cleanPodPolicy }}
-  cleanPodPolicy: Running
-  {{- end }}
+  {{- with .Values.cleanPodPolicy }}
+  cleanPodPolicy: {{ . }}
   {{- end }}
   {{- if .Values.activeDeadlineSeconds }}
   activeDeadlineSeconds: {{ .Values.activeDeadlineSeconds }}