feat(deployment): Enhance Docker ImagePull Secrets Configuration #1754
Conversation
|
@janavenkat thanks for the PR, Lets extend the imagePullSecret configuration to operator deployment model as well. Let me know if anything is needed from my side. |
Sure will add changes for operator as well. |
janavenkat
force-pushed
the
jana/add-image-pull-secrets
branch
2 times, most recently
from
1a6e8ba
to
964e27b
Compare
Added for Operator as well |
janavenkat
force-pushed
the
jana/add-image-pull-secrets
branch
7 times, most recently
from
692973b
to
0f91131
Compare
|
@rksharma95 @daemon1024 , can you please review this PR? Thanks |
There was a problem hiding this comment.
@janavenkat changes looks good assuming that kubearmor helm chart is being used to deploy.
operator uses get pkg to generate kubearmor resources and it will require to add this change there to be in effect.
we've a in-progress action item of major refactoring of kubearmor-operator #1779 we can take care of this feature request as part of it. thanks for your suggestion
janavenkat
force-pushed
the
jana/add-image-pull-secrets
branch
from
0f91131
to
2b8ccc5
Compare
|
@rksharma95 @daemon1024 can we merge this PR? |
In larger production environments, we may get rate-limited by Docker Hub for a lot of image pulls. So, I've added an option for providing the Docker pull secret name to avoid rate limits. Signed-off-by: Jana <[email protected]> Signed-off-by: Jana <[email protected]>
daemon1024
force-pushed
the
jana/add-image-pull-secrets
branch
from
a4415d5
to
8d91905
Compare
In larger production environments, we may get rate-limited by Docker Hub for a lot of image pulls. So, I've added an option for providing the Docker pull secret name to avoid rate limits.
Purpose of PR?:
Add option for passing docker pull secrets in helm template
Does this PR introduce a breaking change?
No
**If the changes in this PR are manually verified, list down the scenarios covered::
Using helm template
Checklist:
<type>(<scope>): <subject>