feat: add multi knowledgebase #981
Merged
+1,648
−589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abirdcfly
force-pushed
the
mulkb
branch
19 times, most recently
from
3e9a662
to
de43bdc
Compare
Abirdcfly
force-pushed
the
mulkb
branch
11 times, most recently
from
30ee741
to
541a7ed
Compare
Abirdcfly
force-pushed
the
mulkb
branch
19 times, most recently
from
5af947f
to
6b774db
Compare
Abirdcfly
force-pushed
the
mulkb
branch
5 times, most recently
from
f582c67
to
14037e6
Compare
Signed-off-by: Abirdcfly <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/kind feature
What this PR does / why we need it
has tested in gpu 167 env, old application also works.
can update to new app node by update app config in web ui.
The above gif shows a complex application that uses 2 knowledgebases, one knowledgebase to provide knowledge of attendance and one knowledgebase to provide knowledge of arbiter and the application uses multiquery and rerank.
Which issue(s) this PR fixes
Fixes #
Special notes for your reviewer
mergerRetrieverto merge multi-knowledgebase like langchain python does.conversation-knowledgebase-placeholderto appruntime and app nodes, this placeholder clearly indicates that there may be a conversation knowledgebase here.knowledgebasestoupdateApplicationConfiggql input and resp for support multiquery knowledgebases, also compatible with the old single knowledgebase model. ( @Carrotzpc front end also need update to support multiquery knowledgebases.)