-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add rag controller #622
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xff-dev
force-pushed
the
eva-controller
branch
2 times, most recently
from
January 24, 2024 01:10
c60956e
to
5992b46
Compare
0xff-dev
force-pushed
the
eva-controller
branch
3 times, most recently
from
January 24, 2024 15:52
5739a2e
to
bbdeec5
Compare
0xff-dev
force-pushed
the
eva-controller
branch
3 times, most recently
from
January 25, 2024 01:34
5f3947c
to
0d972d1
Compare
bjwswang
reviewed
Jan 25, 2024
0xff-dev
force-pushed
the
eva-controller
branch
from
January 25, 2024 07:13
0d972d1
to
7e90fe3
Compare
bjwswang
reviewed
Jan 25, 2024
0xff-dev
force-pushed
the
eva-controller
branch
6 times, most recently
from
January 29, 2024 02:15
ef73486
to
367c772
Compare
bjwswang
requested changes
Jan 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sure you have a successful job run before making this pr merged.
0xff-dev
force-pushed
the
eva-controller
branch
from
January 29, 2024 09:28
6285cb6
to
cd01b3e
Compare
0xff-dev
force-pushed
the
eva-controller
branch
2 times, most recently
from
January 29, 2024 15:36
2b2cacc
to
44998e3
Compare
0xff-dev
force-pushed
the
eva-controller
branch
from
January 30, 2024 01:35
44998e3
to
98923c3
Compare
bjwswang
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it
feat: add rag controller
Which issue(s) this PR fixes
Fix #566
Special notes for your reviewer
The overall implementation logic is
First create the
pvc
and then create 4 stage jobs at a time.The phase changes of rag are
""
,"init"
,"download"
,"generate"
,"judge"
,"upload"
,"complete"
at a time. You can tell if a phase is complete bytype=complete and status=true
in condition.The rag will be suspend, the current stage of the job will be stopped, has been completed will not be processed. rag recovery, the current stage of the job will be re-created to continue execution of the pod, so the need for each stage to ensure that they can support the recovery of the suspend operation, to avoid suspend, after the recovery, the job can not be executed normally.
If the
data source
of the rag, the associatedapplication
, thejudge llm
, or thestorage
changes, it will go back to the first step to re-execute.