-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Extract LLM validate logic & add ZhiPuAI validator #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjwswang
reviewed
Aug 23, 2023
@Lanture1064 You can define a common interface in pkg/llms/llms.go like type Validator interface {
Validate(llmUrl string) error
} Then implement this in different llms. Take zhipuai as an example func (z *ZhiPuAI)Validate(url string) error |
bjwswang
reviewed
Aug 23, 2023
bjwswang
reviewed
Aug 23, 2023
Lanture1064
force-pushed
the
dev
branch
2 times, most recently
from
August 24, 2023 02:22
55f75ad
to
6d2292a
Compare
bjwswang
reviewed
Aug 24, 2023
pkg/llms/zhipuai/api.go
Outdated
if err != nil { | ||
return "", err | ||
} | ||
responseMsg := "TaskID:" + response.Data.TaskID |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the status code in reponse data is 200
,error can be nil here. Otherwise return a error indicates why this failed.
bjwswang
reviewed
Aug 24, 2023
Lanture1064
force-pushed
the
dev
branch
3 times, most recently
from
August 24, 2023 09:30
3688d8a
to
59ae4fb
Compare
Signed-off-by: Lanture1064 <[email protected]>
bjwswang
approved these changes
Aug 24, 2023
nkwangleiGIT
pushed a commit
to nkwangleiGIT/arcadia
that referenced
this pull request
Dec 1, 2023
refactor: Extract LLM validate logic & add ZhiPuAI validator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #28