Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Failed to create Versioneddataset with the inherited historical version #551

Merged
merged 1 commit into from
Jan 12, 2024
Merged

fix: Failed to create Versioneddataset with the inherited historical version #551

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions apiserver/pkg/versioneddataset/versioned_dataset.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,10 +378,19 @@ func CreateVersionedDataset(ctx context.Context, c dynamic.Interface, input *gen
return nil, err
}
if v.Spec.Version == *input.InheritedFrom {
isReady := false
var errMessage error
for _, cond := range v.Status.Conditions {
if !(cond.Type == v1alpha1.TypeReady && cond.Status == v1.ConditionTrue) {
return nil, fmt.Errorf("inherit from a version with an incorrect synchronization state will not be created. reason: %s, errMsg: %s", cond.Reason, cond.Message)
if cond.Type == v1alpha1.TypeReady && cond.Status == v1.ConditionTrue {
isReady = true
break
}
if cond.Type == v1alpha1.TypeReady && cond.Status != v1.ConditionTrue {
errMessage = fmt.Errorf("inherit from a version with an incorrect synchronization state will not be created. reason: %s, errMsg: %s", cond.Reason, cond.Message)
}
}
if !isReady {
return nil, errMessage
}
}
}
Expand Down