feat: optimize model service apis #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abirdcfly
reviewed
Dec 27, 2023
bjwswang
force-pushed
the
chore
branch
3 times, most recently
from
70f711e
to
20895d9
Compare
bjwswang
commented
Dec 27, 2023
| } | ||
| // sort by creation timestamp | ||
| llmList.Nodes = append(llmList.Nodes, embedderList.Nodes...) | ||
| sort.Slice(llmList.Nodes, func(i, j int) bool { |
0xff-dev
reviewed
Dec 27, 2023
Signed-off-by: bjwswang <[email protected]>
0xff-dev
approved these changes
Dec 27, 2023
Abirdcfly
approved these changes
Dec 27, 2023
| @@ -40,6 +40,13 @@ var ( | |||
| StatusFalse = "False" | |||
| ) | |||
|
|
|||
| // ModelType | |||
| var ( | |||
| "github.com/kubeagi/arcadia/pkg/embeddings" | ||
| "github.com/kubeagi/arcadia/pkg/utils" | ||
| ) | ||
|
|
||
| // Embedder2model convert unstructured `CR Embedder` to graphql model `Embedder` |
There was a problem hiding this comment.
Suggested change
| // Embedder2model convert unstructured `CR Embedder` to graphql model `Embedder` | |
| // Embedder2model convert unstructured CR `Embedder` to graphql model `Embedder` |
nit
| // if pageSize is -1 which means unlimited pagesize,return all | ||
| if pageSize == common.UnlimitedPageSize { | ||
| page = 1 | ||
| pageSize = totalCount |
There was a problem hiding this comment.
return &generated.PaginatedResult{
TotalCount: totalCount,
HasNextPage: end < totalCount,
Nodes: result,
}, nil
maybe in line 298, I guess this total is inaccurate, If keyword is not empty, the results have been filtered, but the total number has not changed. HasNextPage will always be true...
It should be a problem elsewhere.
| "github.com/kubeagi/arcadia/pkg/llms" | ||
| "github.com/kubeagi/arcadia/pkg/utils" | ||
| ) | ||
|
|
||
| // LLM2model convert unstructured `CR LLM` to graphql model `Llm` |
There was a problem hiding this comment.
Suggested change
| // LLM2model convert unstructured `CR LLM` to graphql model `Llm` | |
| // LLM2model convert unstructured CR `LLM` to graphql model `Llm` |
nit
| if llm.Spec.Provider.GetType() == v1alpha1.ProviderTypeWorker { | ||
| w, err := worker.ReadWorker(ctx, c, llm.Name, llm.Namespace) | ||
| if err == nil { | ||
| if w.Status != nil { |
There was a problem hiding this comment.
apiserver/pkg/embedder/embedder.go may need also check w.Status != nil
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it
Which issue(s) this PR fixes
Fixes #
Special notes for your reviewer