Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add LLM controller #42

Merged
merged 1 commit into from
Aug 23, 2023
Merged

feat: add LLM controller #42

merged 1 commit into from
Aug 23, 2023

Conversation

Lanture1064
Copy link
Collaborator

Fix: #37

bjwswang
bjwswang reviewed Aug 17, 2023
View reviewed changes
api/v1alpha1/llm_types.go Outdated Show resolved Hide resolved
bjwswang
bjwswang reviewed Aug 17, 2023
View reviewed changes
api/v1alpha1/llm_types.go Outdated Show resolved Hide resolved
bjwswang
bjwswang requested changes Aug 17, 2023
View reviewed changes
Copy link
Collaborator

@bjwswang bjwswang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix the comments

@Lanture1064 Lanture1064 reopened this Aug 21, 2023
@Lanture1064 Lanture1064 marked this pull request as draft August 21, 2023 01:28
@bjwswang
Copy link
Collaborator

@Lanture1064 You can add a LivenessCheck function to openai and zhipuai in this package https://github.com/kubeagi/arcadia/tree/main/pkg/llms

  • For openai: llms/openai/health.go
  • For zhipuai: llms/zhipuai/health.go

@Lanture1064 Lanture1064 marked this pull request as ready for review August 23, 2023 01:49
@Lanture1064
feat: add CRD LLM controller
9a210ca 
Signed-off-by: Lanture1064 <[email protected]>
@bjwswang bjwswang merged commit 75639d3 into kubeagi:main Aug 23, 2023
1 check passed
nkwangleiGIT pushed a commit to nkwangleiGIT/arcadia that referenced this pull request Dec 1, 2023
@bjwswang
Merge pull request kubeagi#42 from Lanture1064/dev
41c00a9 
feat: add LLM controller
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjwswang bjwswang bjwswang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

evaluate llm service
2 participants
@Lanture1064 @bjwswang