fix: create and update auth secret for endpoint in graphql server #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjwswang
commented
Dec 6, 2023
| } | ||
|
|
||
| // MakeAuthSecretName returns a secret name based on its base name and owner's kind | ||
| func MakeAuthSecretName(base string, ownerKind string) string { |
There was a problem hiding this comment.
@Abirdcfly @0xff-dev we can move some common definitions,functions under this package
bjwswang
force-pushed
the
gql
branch
5 times, most recently
from
3f5efbc
to
971d6b6
Compare
Signed-off-by: bjwswang <[email protected]> Changelogs: 1. extract common funcs into pkg/common 2. add some missing fields in graphql server 3. set correct client secret in graphql server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: bjwswang [email protected]
Changelogs:
What type of PR is this?
What this PR does / why we need it
Which issue(s) this PR fixes
Fixes #
Special notes for your reviewer