-
Notifications
You must be signed in to change notification settings - Fork 23
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #293 from 0xff-dev/sync-bucket
feat: create and delete buckets based on namespace changes
- Loading branch information
Showing
7 changed files
with
219 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,169 @@ | ||
| /* | ||
| Copyright 2023 KubeAGI. | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package controllers | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
| "time" | ||
|
|
||
| "github.com/minio/minio-go/v7" | ||
| v1 "k8s.io/api/core/v1" | ||
| "k8s.io/apimachinery/pkg/api/errors" | ||
| "k8s.io/apimachinery/pkg/runtime" | ||
| "k8s.io/apimachinery/pkg/types" | ||
| "k8s.io/klog/v2" | ||
| ctrl "sigs.k8s.io/controller-runtime" | ||
| "sigs.k8s.io/controller-runtime/pkg/builder" | ||
| "sigs.k8s.io/controller-runtime/pkg/client" | ||
| "sigs.k8s.io/controller-runtime/pkg/event" | ||
| "sigs.k8s.io/controller-runtime/pkg/log" | ||
| "sigs.k8s.io/controller-runtime/pkg/predicate" | ||
| "sigs.k8s.io/controller-runtime/pkg/reconcile" | ||
|
|
||
| "github.com/kubeagi/arcadia/pkg/config" | ||
| "github.com/kubeagi/arcadia/pkg/datasource" | ||
| "github.com/kubeagi/arcadia/pkg/utils" | ||
| ) | ||
|
|
||
| const ( | ||
| BucketNotEmpty = "The bucket you tried to delete is not empty" | ||
| BucketNotExist = "The specified bucket does not exist" | ||
|
|
||
| // this is the name of a configmap under the same namespace as operator. the key of the data field is the name of each namespace not to be handled. | ||
| SkipNamespaceConfigMap = "skip-namespaces" | ||
| ) | ||
|
|
||
| type NamespacetReconciler struct { | ||
| client.Client | ||
| Scheme *runtime.Scheme | ||
| } | ||
|
|
||
| //+kubebuilder:rbac:groups="",resources=namespaces,verbs=get;list;watch | ||
|
|
||
| // Reconcile is part of the main kubernetes reconciliation loop which aims to | ||
| // move the current state of the cluster closer to the desired state. | ||
| // TODO(user): Modify the Reconcile function to compare the state specified by | ||
| // the Dataset object against the actual cluster state, and then | ||
| // perform operations to make the cluster state reflect the state specified by | ||
| // the user. | ||
| // | ||
| // For more details, check Reconcile and its Result here: | ||
| // - https://pkg.go.dev/sigs.k8s.io/[email protected]/pkg/reconcile | ||
| func (r *NamespacetReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) { | ||
| _ = log.FromContext(ctx) | ||
|
|
||
| var err error | ||
| instance := &v1.Namespace{} | ||
| if err = r.Client.Get(ctx, req.NamespacedName, instance); err != nil { | ||
| if errors.IsNotFound(err) { | ||
| err = r.removeBucket(ctx, req.Name) | ||
| return reconcile.Result{RequeueAfter: 3 * time.Second}, err | ||
| } | ||
| return reconcile.Result{}, err | ||
| } | ||
| skip, err := r.checkSkippedNamespace(ctx, instance.Name) | ||
| if err != nil { | ||
| return reconcile.Result{}, err | ||
| } | ||
| if skip { | ||
| klog.Infof("namespace %s is in the filter list and will not be created, delete the corresponding bucket.", instance.Name) | ||
| return reconcile.Result{}, nil | ||
| } | ||
|
|
||
| err = r.syncBucket(ctx, instance.Name) | ||
| return ctrl.Result{}, err | ||
| } | ||
|
|
||
| // SetupWithManager sets up the controller with the Manager. | ||
| func (r *NamespacetReconciler) SetupWithManager(mgr ctrl.Manager) error { | ||
| return ctrl.NewControllerManagedBy(mgr). | ||
| For(&v1.Namespace{}, builder.WithPredicates(predicate.Funcs{ | ||
| UpdateFunc: func(ue event.UpdateEvent) bool { | ||
| return false | ||
| }, | ||
| })). | ||
| Complete(r) | ||
| } | ||
|
|
||
| func (r *NamespacetReconciler) ossClient(ctx context.Context) (*datasource.OSS, error) { | ||
| systemDatasource, err := config.GetSystemDatasource(ctx, r.Client) | ||
| if err != nil { | ||
| klog.Errorf("get system datasource error %s", err) | ||
| return nil, err | ||
| } | ||
| endpoint := systemDatasource.Spec.Enpoint.DeepCopy() | ||
| if endpoint.AuthSecret != nil && endpoint.AuthSecret.Namespace == nil { | ||
| endpoint.AuthSecret.WithNameSpace(systemDatasource.Namespace) | ||
| } | ||
| oss, err := datasource.NewOSS(ctx, r.Client, endpoint) | ||
| if err != nil { | ||
| klog.Errorf("generate new minio client error %s", err) | ||
| return nil, err | ||
| } | ||
| return oss, nil | ||
| } | ||
|
|
||
| func (r *NamespacetReconciler) syncBucket(ctx context.Context, namespace string) error { | ||
| oss, err := r.ossClient(ctx) | ||
| if err != nil { | ||
| err = fmt.Errorf("sync bucket: failed to get oss client error %w", err) | ||
| klog.Error(err) | ||
| return err | ||
| } | ||
| exists, err := oss.Client.BucketExists(ctx, namespace) | ||
| if err != nil { | ||
| err = fmt.Errorf("check if the bucket exists and an error occurs, error %w", err) | ||
| klog.Error(err) | ||
| return err | ||
| } | ||
| if !exists { | ||
| klog.Infof("bucket %s does not exist, ready to create bucket", namespace) | ||
| if err = oss.Client.MakeBucket(ctx, namespace, minio.MakeBucketOptions{}); err != nil { | ||
| err = fmt.Errorf("and error osccured creating the bucket, error %w", err) | ||
| klog.Error(err) | ||
| return err | ||
| } | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| func (r *NamespacetReconciler) removeBucket(ctx context.Context, namespace string) error { | ||
| oss, err := r.ossClient(ctx) | ||
| if err != nil { | ||
| err = fmt.Errorf("remove bucket: failed to get oss client error %w", err) | ||
| klog.Error(err) | ||
| return err | ||
| } | ||
| err = oss.Client.RemoveBucket(ctx, namespace) | ||
| if err == nil || err.Error() == BucketNotExist { | ||
| return nil | ||
| } | ||
| return err | ||
| } | ||
|
|
||
| func (r *NamespacetReconciler) checkSkippedNamespace(ctx context.Context, namespace string) (bool, error) { | ||
| cm := v1.ConfigMap{} | ||
| if err := r.Client.Get(ctx, types.NamespacedName{Namespace: utils.GetSelfNamespace(), Name: SkipNamespaceConfigMap}, &cm); err != nil { | ||
| if errors.IsNotFound(err) { | ||
| return false, nil | ||
| } | ||
| return false, err | ||
| } | ||
| _, ok := cm.Data[namespace] | ||
| return ok, nil | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters