Merge pull request #548 from Hoega/exportloopref-linter

Add Exportloopref linter and fix errors

.golangci.yml

@@ -28,6 +28,7 @@ linters:
   disable-all: false # in contrast to golangci.yaml, the default set of linters remains enabled
   enable: # please keep this alphabetized and in sync with golangci.yaml
     - dupword # add by kubeagi
+    - exportloopref
     - ginkgolinter
     - gci # add by kubeagi
     - gocritic

apiserver/pkg/dataset/dataset.go

@@ -54,6 +54,7 @@ func dataset2model(obj *unstructured.Unstructured) (*generated.Dataset, error) {
 	ds.Field = &dataset.Spec.Field
 	first := true
 	for _, cond := range dataset.Status.Conditions {
+		cond := cond
 		if !cond.LastSuccessfulTime.IsZero() {
 			if first || ds.UpdateTimestamp.Before(cond.LastTransitionTime.Time) {
 				ds.UpdateTimestamp = &cond.LastTransitionTime.Time

apiserver/pkg/ray/raycluster.go

@@ -34,6 +34,7 @@ func ListRayClusters(ctx context.Context, c dynamic.Interface, input generated.L
 
 	var results = make([]generated.PageNode, 0, len(clusters))
 	for index, cluster := range clusters {
+		cluster := cluster
 		// skip if keyword not in cluster name
 		if input.Keyword != nil {
 			if !strings.Contains(cluster.Name, *input.Keyword) {

apiserver/pkg/versioneddataset/versioned_dataset.go

@@ -82,6 +82,7 @@ func versionedDataset2model(obj *unstructured.Unstructured) (*generated.Versione
 	vds.DataProcessMsg = new(string)
 	first := true
 	for _, cond := range versioneddataset.Status.Conditions {
+		cond := cond
 		if cond.Type == v1alpha1.TypeReady {
 			*vds.SyncStatus = string(cond.Reason)
 			*vds.SyncMsg = cond.Message