Merge pull request #471 from bjwswang/chore

fix: unmilited page size not working in llm/embedder
kubeagi · Dec 28, 2023 · 3ed0634 · 3ed0634
2 parents e062a95 + 8bc531e
commit 3ed0634
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 7 deletions.
diff --git a/apiserver/graph/schema/modelservice.gql b/apiserver/graph/schema/modelservice.gql
@@ -12,7 +12,8 @@ mutation createModelService($input: CreateModelServiceInput!) {
             providerType
             types
             apiType
-            models
+            llmModels
+            embeddingModels
             creationTimestamp
             updateTimestamp
             status
@@ -36,7 +37,8 @@ mutation updateModelService($input: UpdateModelServiceInput) {
             providerType
             types
             apiType
-            models
+            llmModels
+            embeddingModels
             creationTimestamp
             updateTimestamp
             status
@@ -66,7 +68,8 @@ query getModelService($name: String!, $namespace: String!) {
             providerType
             types
             apiType
-            models
+            llmModels
+            embeddingModels
             creationTimestamp
             updateTimestamp
             status
@@ -95,7 +98,8 @@ query listModelServices($input: ListModelServiceInput) {
                     providerType
                     types
                     apiType
-                    models
+                    llmModels
+                    embeddingModels
                     creationTimestamp
                     updateTimestamp
                     status

diff --git a/apiserver/pkg/embedder/embedder.go b/apiserver/pkg/embedder/embedder.go
@@ -243,7 +243,7 @@ func ListEmbedders(ctx context.Context, c dynamic.Interface, input generated.Lis
 	if input.Page != nil && *input.Page > 0 {
 		page = *input.Page
 	}
-	if input.PageSize != nil && *input.PageSize > 0 {
+	if input.PageSize != nil {
 		pageSize = *input.PageSize
 	}
 

diff --git a/apiserver/pkg/llm/llm.go b/apiserver/pkg/llm/llm.go
@@ -117,7 +117,7 @@ func ListLLMs(ctx context.Context, c dynamic.Interface, input generated.ListComm
 	if input.Page != nil && *input.Page > 0 {
 		page = *input.Page
 	}
-	if input.PageSize != nil && *input.PageSize > 0 {
+	if input.PageSize != nil {
 		pageSize = *input.PageSize
 	}
 

diff --git a/apiserver/pkg/worker/worker.go b/apiserver/pkg/worker/worker.go
@@ -327,7 +327,7 @@ func ListWorkers(ctx context.Context, c dynamic.Interface, input generated.ListW
 	if input.Page != nil && *input.Page > 0 {
 		page = *input.Page
 	}
-	if input.PageSize != nil && *input.PageSize > 0 {
+	if input.PageSize != nil {
 		pageSize = *input.PageSize
 	}