Skip to content

Commit

Permalink
hype it down a bit after rolling it out more
Browse files Browse the repository at this point in the history
Signed-off-by: clux <[email protected]>
  • Loading branch information
clux committed Jun 12, 2024
1 parent b47dda1 commit 2c18e19
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion docs/blog/posts/2024-06-11-reflector-memory.md
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ Thus, on a restart, objects are passed one-by-one up to the store, and buffered

The initial setup saw **60% improvements** to [synthetic benchmarks](https://github.com/kube-rs/kube/pull/1494#issue-2292501600) when using stores, and **upwards of 80%** when not using stores (when there's nothing to cache), with further incremental improvements when using the `StreamingList` strategy

I have seen [50% drops myself in real-world controllers](https://github.com/kube-rs/kube/pull/1494#issuecomment-2126694967). YMMW, particularly if you are doing a lot of other stuff, but please [reach out](https://discord.gg/tokio) with more results.
Real world benefits are expected to be smaller. So far we have seen controllers with a basically unchanged profile, some with small improvements in the 10-20% range, but I did get one [50% drop in a real-world controller](https://github.com/kube-rs/kube/pull/1494#issuecomment-2126694967) (ironically, the one I used to test the change). So YMMW, particularly if you are doing a lot of other stuff, but please [reach out](https://discord.gg/tokio) with more results.

## Thoughts for the future

Expand Down
1 change: 1 addition & 0 deletions includes/abbreviations.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,4 @@
*[SLA]: Service Level Agreement
*[SLO]: Service Level Objective
*[P95]: 95th Percentile
*[YMMV]: Your Mileage May Vary

0 comments on commit 2c18e19

Please sign in to comment.