WA: Disable JS legacy transformation manually until it is completely removed from the atomicfu plugin. #4313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you check the CI build error? Error: |
…removed from the atomicfu plugin.
mvicsokolova
force-pushed
the
kotlin-community/disable-atomicfu-js
branch
from
58b41da
to
9c88555
Compare
|
Seems that now, my fix is not the reason of the build failure anymore. @bjhham could please have a look? 🙏 Also, I've changed the base branch from |
mvicsokolova
commented
Sep 23, 2024
build.gradle.kts
Outdated
| @@ -102,7 +102,7 @@ apply(from = "gradle/compatibility.gradle") | |||
| plugins { | |||
| id("org.jetbrains.dokka") version "1.9.20" apply false | |||
| id("org.jetbrains.kotlinx.binary-compatibility-validator") version "0.16.3" | |||
| id("org.jetbrains.kotlinx.atomicfu") version "0.25.0" apply false | |||
| //id("org.jetbrains.kotlinx.atomicfu") version "0.25.0" apply false | |||
There was a problem hiding this comment.
What was the original purpose of disabling the plugin here? 👀
There was a problem hiding this comment.
I think the purpose is to add the plugin to the build classpath but apply it later
e5l
reviewed
Sep 25, 2024
e5l
approved these changes
Sep 25, 2024
|
LGTM, will be merged after CI check |
woainikk
pushed a commit
that referenced
this pull request
Oct 2, 2024
…removed from the atomicfu plugin. (#4313)
woainikk
pushed a commit
that referenced
this pull request
Oct 10, 2024
…removed from the atomicfu plugin. (#4313) * WA: Disable JS legacy transformation manually until it is completely removed from the atomicfu plugin. * fixup! Fix getting the atomicfu version from libs * Update build.gradle.kts --------- Co-authored-by: Leonid Stashevsky <[email protected]>
woainikk
added a commit
that referenced
this pull request
Oct 10, 2024
…removed from the atomicfu plugin. (#4313) * WA: Disable JS legacy transformation manually until it is completely removed from the atomicfu plugin. * fixup! Fix getting the atomicfu version from libs * Update build.gradle.kts --------- Co-authored-by: Leonid Stashevsky <[email protected]>
woainikk
pushed a commit
that referenced
this pull request
Oct 10, 2024
…removed from the atomicfu plugin. (#4313) * WA: Disable JS legacy transformation manually until it is completely removed from the atomicfu plugin. * fixup! Fix getting the atomicfu version from libs * Update build.gradle.kts --------- Co-authored-by: Leonid Stashevsky <[email protected]>
woainikk
added a commit
that referenced
this pull request
Oct 11, 2024
…removed from the atomicfu plugin. (#4313) * WA: Disable JS legacy transformation manually until it is completely removed from the atomicfu plugin. * fixup! Fix getting the atomicfu version from libs
woainikk
pushed a commit
that referenced
this pull request
Oct 11, 2024
…removed from the atomicfu plugin. (#4313) * WA: Disable JS legacy transformation manually until it is completely removed from the atomicfu plugin. * fixup! Fix getting the atomicfu version from libs * Update build.gradle.kts --------- Co-authored-by: Leonid Stashevsky <[email protected]>
woainikk
pushed a commit
that referenced
this pull request
Oct 11, 2024
…removed from the atomicfu plugin. (#4313) * WA: Disable JS legacy transformation manually until it is completely removed from the atomicfu plugin. * fixup! Fix getting the atomicfu version from libs * Update build.gradle.kts --------- Co-authored-by: Leonid Stashevsky <[email protected]>
woainikk
pushed a commit
that referenced
this pull request
Oct 11, 2024
…removed from the atomicfu plugin. (#4313) * WA: Disable JS legacy transformation manually until it is completely removed from the atomicfu plugin. * fixup! Fix getting the atomicfu version from libs * Update build.gradle.kts --------- Co-authored-by: Leonid Stashevsky <[email protected]>
woainikk
pushed a commit
that referenced
this pull request
Oct 14, 2024
…removed from the atomicfu plugin. (#4313)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes this train failure.
Through an oversight
atomicfu-gradle-pluginkept tranformJs option (corresponding to the legacy JS transformation) enabled by default, and with no *.js files to transform it just copied the compileJs output directory.Here is the similar fix merged into kotlinx.coroutines: Kotlin/kotlinx.coroutines#4223