doc for return response headers from v1 and v2 endpoints #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrews Arokiam <[email protected]>
✅ Deploy Preview for elastic-nobel-0aef7a ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
yuzisun
reviewed
Nov 4, 2024
| @@ -65,6 +70,9 @@ if __name__ == "__main__": | |||
| ModelServer().start([model]) | |||
| ``` | |||
|
|
|||
| !!! note | |||
| `return_response_headers=True` will be used to return response headers from v1 and v2 endpoints | |||
There was a problem hiding this comment.
Suggested change
| `return_response_headers=True` will be used to return response headers from v1 and v2 endpoints | |
| `return_response_headers=True` can be added to return response headers for v1 and v2 endpoints |
There was a problem hiding this comment.
This applies to preprocess, predict and postprocess also right?
yuzisun
reviewed
Nov 4, 2024
| self, | ||
| payload: Dict, | ||
| headers: Dict[str, str] = None, | ||
| response_headers: Dict[str, str] = None, |
There was a problem hiding this comment.
Also add the example code you have to add the response header ?
Signed-off-by: Andrews Arokiam <[email protected]>
|
/lgtm |
yuzisun
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Fixes #issue-number" or "Add description of the problem this PR solves"
Proposed Changes