-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: First InferenceService instructions with port-forwarding #412
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for elastic-nobel-0aef7a ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
a1a6ca4
to
f4e029d
Compare
docs/get_started/first_isvc.md
Outdated
|
||
```bash | ||
SERVICE_HOSTNAME=$(kubectl get inferenceservice sklearn-iris -n kserve-test -o jsonpath='{.status.url}' | cut -d "/" -f 3) | ||
curl -v -H "Host: ${SERVICE_HOSTNAME}" -H "Content-Type: application/json" "http://${INGRESS_HOST}:${INGRESS_PORT}/v1/models/sklearn-iris:predict" -d @./iris-input.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe instead adding a new section, what about add the command curl command after https://github.com/kserve/website/pull/412/files#diff-2066f8cd5b8985c4a57b1da95f0b1da8277507031b72a35759bd066b47d11ee3R121
btw, is think there is no need to pass the SERVICE_HOSTNAME
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the PR to add the curl command where you suggested. I think I had to modify the SERVICE_HOSTNAME section to work correctly.
Signed-off-by: Nimisha Mehta <[email protected]>
11b25a1
to
2535ebd
Compare
@nimishamehta5 The preview is not rendering the page. Can you check if it is rendering for you in your local machine ? |
@sivanantha321 I think that's a different issue unrelated to my change, I reported this in #411 and it was fixed, but my branch is not rebased on to the main one |
Adds a small section to the Getting Started > First InferenceService docs on how to curl against a locally running port-forwarded server.