Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: First InferenceService instructions with port-forwarding #412

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nimishamehta5
Copy link

@nimishamehta5 nimishamehta5 commented Oct 23, 2024

Adds a small section to the Getting Started > First InferenceService docs on how to curl against a locally running port-forwarded server.

Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for elastic-nobel-0aef7a ready!

Name Link
🔨 Latest commit 2535ebd
🔍 Latest deploy log https://app.netlify.com/sites/elastic-nobel-0aef7a/deploys/672c424ab53fa100089ae48a
😎 Deploy Preview https://deploy-preview-412--elastic-nobel-0aef7a.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.


```bash
SERVICE_HOSTNAME=$(kubectl get inferenceservice sklearn-iris -n kserve-test -o jsonpath='{.status.url}' | cut -d "/" -f 3)
curl -v -H "Host: ${SERVICE_HOSTNAME}" -H "Content-Type: application/json" "http://${INGRESS_HOST}:${INGRESS_PORT}/v1/models/sklearn-iris:predict" -d @./iris-input.json
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe instead adding a new section, what about add the command curl command after https://github.com/kserve/website/pull/412/files#diff-2066f8cd5b8985c4a57b1da95f0b1da8277507031b72a35759bd066b47d11ee3R121

btw, is think there is no need to pass the SERVICE_HOSTNAME

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the PR to add the curl command where you suggested. I think I had to modify the SERVICE_HOSTNAME section to work correctly.

@sivanantha321
Copy link
Member

@nimishamehta5 The preview is not rendering the page. Can you check if it is rendering for you in your local machine ?
Screenshot from 2024-11-07 10-10-45

@nimishamehta5
Copy link
Author

@sivanantha321 I think that's a different issue unrelated to my change, I reported this in #411 and it was fixed, but my branch is not rebased on to the main one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants