Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce GH action for building images with specific version #29

Merged
merged 4 commits into from
Feb 14, 2022

Conversation

kimwnasptd
Copy link
Contributor

Refs #26

This PR:

  1. Introduces a releasing directory with helpers for managing the app's release
  2. A GH action that uses the releasing/VERSION file to push an image with specific tag, when that file changes

Signed-off-by: Kimonas Sotirchos <[email protected]>
@kimwnasptd
Copy link
Contributor Author

@StefanoFioravanzo @elikatsis this should be ready for review. We need this in order for the web app to have versions, which I can then include in the KF 1.5 release kubeflow/manifests#2110

This PR:

  1. Introduces a releasing/VERSION file, similarly to the one we have in https://github.com/kubeflow/kubeflow/blob/master/releasing/version/VERSION
  2. Adds a GH action that will run only when the releasing/VERSION is file. It will build the image with that specific tag and push it

Signed-off-by: Kimonas Sotirchos <[email protected]>
@StefanoFioravanzo
Copy link

/lgtm
/approve

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kimwnasptd, StefanoFioravanzo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kimwnasptd
Copy link
Contributor Author

It seems that this PR can't be merged as well. @Tomcli any guesses?

@StefanoFioravanzo is a member of KSERVE and I also see in tide's status that the PR is in STATE: MERGE #29 https://kserve-prow-442dbba0442be6c8c50f31ed96b00601-0000.us-south.containers.appdomain.cloud/tide.

I'll move on and manually merge this on, since I needed for the KF release.

@kimwnasptd kimwnasptd merged commit 42220c5 into kserve:master Feb 14, 2022
@kimwnasptd kimwnasptd deleted the feature-kimwnasptd-mwa-manifests branch February 14, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants