-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upgrade to Go 1.21 (rebase developer image from ubi/go-toolset to ubi-minimal) #487
Conversation
Signed-off-by: Christian Kadner <[email protected]>
Signed-off-by: Christian Kadner <[email protected]>
Signed-off-by: Christian Kadner <[email protected]>
I am leaving this PR as is:
I am not yet:
In order to keep the changes to a minimum and make it easier to back track should there be unforeseen side effects. I will create separate PRs for the UBI and KServe upgrades, as the UBI upgrade spans several repositories and the KServe update has a long tail of related changes that require a bit more work. |
Signed-off-by: Christian Kadner <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ckadner, rafvasq The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ckadner, rafvasq The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Motivation
In preparation of the v0.12.0 release of ModelMesh Serving, we need to upgrade from Go 1.20 to Go 1.21 as required by KServe v0.12.0.
Since there will not be a UBI
go-toolset
image for Go1.21
until 2Q 2024, we need to "rebase" the Developer image fromubi8/go-toolset:1.20
toubi8/ubi-minimal:8.9
and install all required tools that would otherwise be provided "out of the box".Modifications
First step, "rebase" the Developer image from
ubi8/go-toolset:1.20
toubi8/ubi-minimal:8.9
and install Go 1.20.10 along with all required tools. Keep with Go 1.20.10 at first to ensure there are no regressions.Result
TBD - Work in progress