Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade to Go 1.21 (rebase developer image from ubi/go-toolset to ubi-minimal) #487

Merged
merged 4 commits into from
Jan 31, 2024

Conversation

ckadner
Copy link
Member

@ckadner ckadner commented Jan 31, 2024

Motivation

In preparation of the v0.12.0 release of ModelMesh Serving, we need to upgrade from Go 1.20 to Go 1.21 as required by KServe v0.12.0.

Since there will not be a UBI go-toolset image for Go 1.21 until 2Q 2024, we need to "rebase" the Developer image from ubi8/go-toolset:1.20 to ubi8/ubi-minimal:8.9 and install all required tools that would otherwise be provided "out of the box".

Modifications

First step, "rebase" the Developer image from ubi8/go-toolset:1.20 to ubi8/ubi-minimal:8.9 and install Go 1.20.10 along with all required tools. Keep with Go 1.20.10 at first to ensure there are no regressions.

Result

TBD - Work in progress

@ckadner ckadner self-assigned this Jan 31, 2024
@ckadner ckadner marked this pull request as draft January 31, 2024 08:18
@kserve kserve deleted a comment from oss-prow-bot bot Jan 31, 2024
Signed-off-by: Christian Kadner <[email protected]>
Signed-off-by: Christian Kadner <[email protected]>
@ckadner ckadner marked this pull request as ready for review January 31, 2024 17:20
@oss-prow-bot oss-prow-bot bot requested a review from njhill January 31, 2024 17:20
@ckadner ckadner changed the title chore: Replace go-toolset developer image chore: Upgrade to Go 1.21 (rebase developer image from ubi/go-toolset to ubi-minimal) Jan 31, 2024
@ckadner
Copy link
Member Author

ckadner commented Jan 31, 2024

@spolti @rafvasq

I am leaving this PR as is:

  • rebase dev image (ubi/go-toolset:1:20 => ubi8/ubi-minimal:8.9)
  • update Go version (1.20 => 1.21)

I am not yet:

  • upgrading KServe (v0.11.2 => v0.12.0-rc1)
  • not switching UBI base (ubi8 => ubi9)

In order to keep the changes to a minimum and make it easier to back track should there be unforeseen side effects.

I will create separate PRs for the UBI and KServe upgrades, as the UBI upgrade spans several repositories and the KServe update has a long tail of related changes that require a bit more work.

go.mod Outdated Show resolved Hide resolved
Signed-off-by: Christian Kadner <[email protected]>
@ckadner ckadner requested a review from spolti January 31, 2024 19:03
Copy link

oss-prow-bot bot commented Jan 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ckadner, rafvasq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
Copy link

oss-prow-bot bot commented Jan 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ckadner, rafvasq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ckadner ckadner merged commit ef985c8 into kserve:main Jan 31, 2024
9 of 10 checks passed
@ckadner
Copy link
Member Author

ckadner commented Jan 31, 2024

Thanks @spolti @rafvasq for your reviews

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants