feat: for APPLAUNCHER-28 various data fixes #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sinjhin
changed the title
Sinjhin
changed the title
|
@Sinjhin Is this ready for review? |
|
plz tag me for review so I know, oh and pics or it didn't happen :) |
|
@krumware Also throwing in here the componentization of the ClusterActions, ClusterGridView, and ClusterListView |
krumware
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
I don't necessarily like how this is positioned (if I turn off the negative margin on the container, it looks like this)
but everything else looks good and that will serve for now. If you can add a tech debt (low priority) for the positioning on that it would be awesome.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing some data structures so far to make it easier and more apparent where each property from an Ingress or Service is coming from and to align more with the data from Rancher.
Also throwing in here the componentization of the
ClusterActions,ClusterGridView, andClusterListViewAddresses:
Current:
┆Issue is synchronized with this Jira Task by Unito