CI: Bump bitcoind to 26.0

.github/workflows/tests.yml

@@ -6,7 +6,7 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        bitcoind-version: ["0.17.2", "24.0"]
+        bitcoind-version: ["0.17.2", "26.0"]
         os: [macos-latest, ubuntu-latest]
     steps:
       - uses: actions/checkout@v3

ricochet-send.sh

@@ -111,7 +111,7 @@ rawtx="$(show_tx_by_id "$txid")"
 #echo "$rawtx"
 vout_idx=""
 idx=0
-while read -r vout_address; do
+while read -u 3 -r vout_address; do
     if [ "$vout_address" == "${ricochet_addresses[0]}" ]; then
         vout_idx=$idx
         value="$(echo "$rawtx" | jq -r ".vout[$vout_idx].value")"
@@ -121,7 +121,7 @@ while read -r vout_address; do
         fi
     fi
     ((idx++))
-done <<< "$(get_decoded_tx_addresses "$rawtx")"
+done 3< <(get_decoded_tx_addresses "$rawtx")
 if [ "$prev_pubkey" == "" ]; then
     echoerr "$rawtx"
     echoerr "FATAL: Can't find the right vout in the first transaction, please fill a bug report!"
@@ -133,6 +133,7 @@ use_txid="$txid"
 
 # Prepare and sign rest of transactions
 echo "Preparing rest of transactions..."
+set -x
 signedtxes=()
 for i in $(seq 1 $(( hops - 1 ))); do
     send_amount="$(bc_float_calc "$send_amount - ${ricochet_fees[$i]}")"
@@ -147,6 +148,7 @@ for i in $(seq 1 $(( hops - 1 ))); do
     prev_pubkey="$(echo "$decodedtx" | jq -r ".vout[].scriptPubKey.hex")"
     echo "$use_txid"
 done
+set +x
 
 #printf '%s\n' "${signedtxes[@]}"
 

tests/functional/inc.setup.sh

@@ -16,12 +16,15 @@ fi
 # shellcheck disable=SC2034
 retval=0
 
-#set -x
+set -x
 
 rm -rf "$bitcoin_test_datadir"
 mkdir "$bitcoin_test_datadir"
 echo -e "[regtest]\nrpcuser=bitcoinrpc\nrpcpassword=123456abcdef" \
     > "$bitcoin_test_datadir/bitcoin.conf"
+if [[ "$($bitcoind -version | grep -Eo 'v[0-9]+')" == "v26" ]]; then
+    echo "deprecatedrpc=create_bdb" >> "$bitcoin_test_datadir}/bitcoin.conf"
+fi
 $bitcoind -daemon || exit 1
 # Wait until bitcoind has started properly
 while ! $bitcoin_cli getblockchaininfo 2> /dev/null; do sleep 0.1; done
@@ -31,6 +34,7 @@ if [[ "$($bitcoin_cli listwallets | jq ". | length")" == "0" ]]; then
         # fallback for old Core versions
         $bitcoin_cli createwallet tests
     fi
+    bitcoin_cli="$bitcoin_cli -rpcwallet=tests"
 fi
 #$bitcoin_cli loadwallet tests
 # Generate some coins