Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reaction not show because the width too big #485

Closed
wants to merge 1 commit into from

Conversation

Decodetalkers
Copy link
Contributor

so I want to fix this problem

before
image

after

image

@Decodetalkers Decodetalkers force-pushed the reactions branch 2 times, most recently from 80c8e81 to d339fc5 Compare August 4, 2023 14:19
@Decodetalkers Decodetalkers force-pushed the reactions branch 3 times, most recently from a7cf1f6 to 951ef35 Compare August 8, 2023 08:47
@q234rty
Copy link
Contributor

q234rty commented Oct 1, 2023

I confirm this fixes custom reactions for me.
Gentle ping on this @krille-chan

@krille-chan
Copy link
Owner

Can you add steps to reproduce please?

@q234rty
Copy link
Contributor

q234rty commented Oct 29, 2023

I assume it's just "send a custom reaction in any client that supports that, and observe that the reaction is not rendered in fluffychat"

@q234rty
Copy link
Contributor

q234rty commented Jan 8, 2024

ping? mxc:// reactions are still broken on 0.17.0

@Akselmo
Copy link

Akselmo commented May 4, 2024

Can you add steps to reproduce please?

  1. Join to a chat that is bridged to discord with mautrix-discord bridge.

  2. React to someones message with custom emoji on discord side.

  3. Check fluffychat for the same message

Basically the reaction is mxc image link that needs to be parsed proper.

@krille-chan
Copy link
Owner

Not sure if this is the correct approach. A SingleChildScrollView has a huge performance impact. If there are a lot of reactions visible on the screen, this might become laggy

@Akselmo
Copy link

Akselmo commented May 4, 2024

Good to know, is there any different potential solutions? This isnt my PR but just asking in behalf of contributors (or maybe i could try fix it as well since i can reliably repro it! I am just not android dev at all.. 😅 )

@krille-chan
Copy link
Owner

In the latest commit on main I have no added a fix. For some reason the width of an mxc reaction was set to 9999? However just setting it to width and height of 20 seems to easily fix it for me. Or am I missing something here?

It now looks like this (tested with one of my own stickers):

Bildschirmfoto vom 2024-05-05 09-28-23
Bildschirmfoto vom 2024-05-05 09-28-32

@Decodetalkers
Copy link
Contributor Author

but sometimes it will be a long letter. emm

@Decodetalkers
Copy link
Contributor Author

Seems fixed, so now I will close this pr, thanks very much

@Akselmo
Copy link

Akselmo commented May 5, 2024

Seems to work for me as well on the web nightly at least, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants