Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: option to not send typing notifications #473

Merged
merged 1 commit into from
Jul 27, 2023
Merged

feat: option to not send typing notifications #473

merged 1 commit into from
Jul 27, 2023

Conversation

Bnyro
Copy link
Contributor

@Bnyro Bnyro commented Jul 27, 2023

closes #338

Copy link
Owner

@krille-chan krille-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is perfect! You did a great job integrating your code changes into the existing system so it was super easy to review for me. Thank you so much <3

auto-merge was automatically disabled July 27, 2023 15:02

Head branch was pushed to by a user without write access

@Bnyro
Copy link
Contributor Author

Bnyro commented Jul 27, 2023

Thank you for the lovely feedback, I do really appreciate that <3

I'm not really familiar with the dart linter, that seems to be my biggest (and only) problem with this PR. I hope it shouldn't complain anymore now :)

@krille-chan
Copy link
Owner

Import sorting check failed. Can you run dart run import_sorter:main --no-comments in your branch please?

auto-merge was automatically disabled July 27, 2023 16:15

Head branch was pushed to by a user without write access

auto-merge was automatically disabled July 27, 2023 17:10

Head branch was pushed to by a user without write access

@krille-chan krille-chan merged commit 6172818 into krille-chan:main Jul 27, 2023
5 checks passed
@Bnyro Bnyro deleted the disable-typing-notifications branch July 27, 2023 17:39
@basings basings mentioned this pull request Jan 23, 2024
@Henry-Hiles Henry-Hiles mentioned this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option not to send typing event
2 participants