Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Krille/import emoji improvements #468

Merged

Conversation

krille-chan
Copy link
Owner

No description provided.

@@ -23,6 +25,31 @@ class EmotesSettingsView extends StatelessWidget {
appBar: AppBar(
leading: const BackButton(),
title: Text(L10n.of(context)!.emoteSettings),
actions: [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I honestly prefer the prominent buttons but I can understand it's not anyone's preference. LGTM hence apart from the comment above.

@TheOneWithTheBraid TheOneWithTheBraid merged commit e94fe74 into braid/emoji-import-github Jul 24, 2023
5 checks passed
@TheOneWithTheBraid TheOneWithTheBraid deleted the krille/import-emoji-improvements branch July 24, 2023 18:19
@TheOneWithTheBraid
Copy link
Collaborator

Merged. Kan you review my PR in favor ?

Decodetalkers pushed a commit to Decodetalkers/fluffychat that referenced this pull request Aug 7, 2023
* refactor: Move GUI into Popupmenu
* refactor: Reuse save file method from MatrixFile
@basings basings mentioned this pull request Jan 23, 2024
@Henry-Hiles Henry-Hiles mentioned this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants