Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use the emoji picker's search in getSuggestions #455

Closed
wants to merge 2 commits into from

Conversation

TheSunCat
Copy link
Contributor

Fixes #420
Tested on Linux and Android.

@TheOneWithTheBraid
Copy link
Collaborator

I really like the changes.

Two points to be considered :

  • the renderer still uses package:emojis. In order to properly match all Emojis, it might be useful to sync the renderer using the other package too. E.g. 👩‍❤️‍👩 as a newer Emoji is simply recognized as regular text
  • how far does that packages support skin tones ? In the drop down list I was only proposed yellow emojis

(Both should not block this PR but rather be discussed later.)

@TheOneWithTheBraid
Copy link
Collaborator

Dart analyzer fails, can you please apply dart format lib/ test/ and dart run import_sorter:main --no-comments ? Thanks !

@TheSunCat
Copy link
Contributor Author

I really like the changes.

Thanks!

* the renderer still uses `package:emojis`. In order to properly match all Emojis, it might be useful to sync the renderer using the other package too. E.g. `👩‍❤️‍👩 ` as a newer Emoji is simply recognized as regular text

I don't know much about package:emojis (pretty new to Flutter) but it seems reasonable to use this package for everything emoji-related, so as to have consistent behavior througouht FluffyChat.

* how far does that packages support skin tones ? In the drop down list I was only proposed yellow emojis

This is the same package that was used for the emoji picker that comes up under the chat bar, which supports skin tones by long-tapping an emote. This is not really an option here as the suggestions list is awkward enough that long-tapping would be too much in my opinion.
An idea would be to support a global "default skin tone" option (maybe add a selector to the right of the emoji search bar from #454) to be used in this list. This would also allow faster access to sending an emote with the user's preferred skin tone from the emoji drawer, as they currently have to long-tap each emoji every time they need to send it.

Copy link

This pull request is stale because it has been open for 120 days with no activity.

@github-actions github-actions bot added the stale The item is going to be closed soon because of inactivity label Dec 26, 2023
Copy link

github-actions bot commented Jan 9, 2024

This pull request was closed because it has been inactive for 14 days since being marked as stale.

@github-actions github-actions bot closed this Jan 9, 2024
@basings basings mentioned this pull request Jan 23, 2024
@Henry-Hiles Henry-Hiles mentioned this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale The item is going to be closed soon because of inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

emoji auto complete is kinda broken
2 participants