Add pre-commit and .gitattributes for small style fixes and EOL normalisation #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At least the checks pass now |
Closed
Closed
|
This pull request is stale because it has been open for 120 days with no activity. |
github-actions
bot
added
the
stale
|
I guess I should update this as there are new merge conflicts |
|
Or not as I have headache and there is no interest anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was hoping the large file check would detect #449 and give instructions for proceeding, but while that didn't happen, this configuration hit a lot of missing EOFs, trailing whitespaces and one incident of executable
.desktop.The EOL normalisation is something I am just used to performing for my repositories as
eol=lfwhile this just looks at which platform git is ran on and uses lf on Linux and macOS, crlf on Windows and I think internally everything is lf. A couple of files that appear rewritten were caught bygit add --renormalize ..In case this is desirable, the next step would be enabling https://pre-commit.ci for the repository