Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve banners #1358

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

connyduck
Copy link

@connyduck connyduck commented Sep 22, 2024

Problems with the existing banners:

  • The icons in the background are not tiled correctly (there is more space on the right side of the banner than on the left side)
  • The transparent banner has white transparency artifacts (it probably was created by converting white to transparency) that make it look weird when rendered over a dark background, e.g. when Fluffychat is in dark mode.

I corrected the background tiles and changed the transparent banner to make sure it looks good no matter which background it is displayed over.

Otherwise I tried to stay as close to the existing banners as possible.

The new banner over white background:
banner

The new banner over dark background:
banner_dark

The banner inside the Android app:
Screenshot_20240922_120104

  • Code formatting and import sorting has been done with dart format lib/ test/ and dart run import_sorter:main --no-comments
  • The commit message uses the format of Conventional Commits
  • The commit message describes what has been changed, why it has been changed and how it has been changed
  • Every new feature or change of the design/GUI is linked to an approved design proposal in an issue
  • Every new feature in the app or the build system has a strategy how this will be tested and maintained from now on for every release, e.g. a volunteer who takes over maintainership

Pull Request has been tested on:

  • Android
  • iOS
  • Browser (Chromium based)
  • Browser (Firefox based)
  • Browser (WebKit based)
  • Desktop Linux
  • Desktop Windows
  • Desktop macOS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant