feat(report): allow override of report timestamp dir structure #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwbruhn
force-pushed
the
pathTimestampFormat
branch
3 times, most recently
from
beb628c
to
24d01fe
Compare
grawk
requested changes
Sep 21, 2020
| @@ -47,7 +47,8 @@ const reportDir = function reportDir(cb) { | |||
| log('reportDir: output:reports not defined'); | |||
| return cb(null, this); | |||
| } | |||
| let tsDirName = moment().format('MM-DD-YYYY/HH-mm-ss'); | |||
| const pathTimestampFormat = this.config.get('output:pathTimestampFormat') || 'MM-DD-YYYY/HH-mm-ss'; | |||
| let tsDirName = moment().format(pathTimestampFormat); | |||
There was a problem hiding this comment.
Since this is a user supplied configuration, we may want to wrap this in a try/catch or otherwise figure out how to handle the case where the value provided is invalid.
There was a problem hiding this comment.
I'm also interested in what issues arise if we pass in a "valid" but unexpected value like foo. Will we run into errors if multiple tests/runs try to write to the same folder?
Perhaps we don't have to handle all these cases and users will be able determine the errors are due to their custom config value 🤷♂️
skratchdot
approved these changes
Sep 21, 2020
| @@ -82,7 +82,7 @@ | |||
| "yargs": "^15.0.1" | |||
| }, | |||
| "devDependencies": { | |||
| "chromedriver": "^83.0.0", | |||
| "chromedriver": "^85.0.1", | |||
There was a problem hiding this comment.
we can change this to:
"chromedriver": "latest",
so we don't have to keep updating this value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
output.pathTimestampFormatconfig option to allow overriding of timestamp folder structure. (I'd like to put the year first, myself.)@grawk Appreciate any pointers on adding tests!