Increase unit test coverage in the dom file 🧪 #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borodovisin
changed the title
wsbrunson
approved these changes
Apr 19, 2022
borodovisin
force-pushed
the
DTPPSDK-721/dom-test
branch
from
f3138da
to
dd57509
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR increases the test coverage over the
dom.jsfile. Do not cover all the code in the file, it's the first iteration of increasing the coverageWhy are we making these changes?
To increase the coverage gradually.
Caveats
In my case, I do not find a clean way to test asynchronous code using karma/mocha env. Meaning the test trying to assert something inside a
thenresponse fromZalgoPromiseis not a good idea and a bad practice. If the Promise does not resolve we aren't able to execute the assertion.