Skip to content

Commit

Permalink
feat: used mixed for JSON-able types (#78)
Browse files Browse the repository at this point in the history
  • Loading branch information
wsbrunson authored Aug 18, 2023
1 parent 68ffdf1 commit 46d94fd
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
1 change: 0 additions & 1 deletion src/logger.js
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,6 @@ export function Logger({
print(
LOG_LEVEL.DEBUG,
`metric.${metricPayload.metricNamespace}`,
// $FlowIssue difference between Payload and metric dimensions
metricPayload.dimensions || {}
);

Expand Down
4 changes: 2 additions & 2 deletions src/types.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/* @flow */

export type Payload = { [string]: string | boolean | null | void };
export type Payload = { [string]: mixed };

export type MetricPayload = {|
metricNamespace: string, // the name of the metric that's used for charting / finding in signalFx
Expand All @@ -12,5 +12,5 @@ export type MetricPayload = {|
* - https://engineering.paypalcorp.com/confluence/pages/viewpage.action?pageId=981633893
* - https://engineering.paypalcorp.com/confluence/display/Checkout/Checkout+Observability+Overview
*/
dimensions?: { [string]: string },
dimensions?: { [string]: mixed },
|};

0 comments on commit 46d94fd

Please sign in to comment.