Merge pull request #44 from krakendio/fix_post_error

Improve test coverage of the proxy pkg
krakend · Jun 28, 2023 · b933880 · b933880
2 parents ed2eb32 + 7923ad1
commit b933880
Show file tree

Hide file tree

Showing 2 changed files with 80 additions and 3 deletions.
diff --git a/proxy/http_test.go b/proxy/http_test.go
@@ -36,7 +36,8 @@ func Example_RegisterBackendModule() {
 	code := fmt.Sprintf("local url = '%s'\n%s", ts.URL, sampleLuaCode)
 
 	if err := bindr.DoString(code); err != nil {
-		fmt.Println(err)
+		fmt.Println(err.(*binder.Error).Error())
+		err.(*binder.Error).Print()
 	}
 
 	// output:
@@ -64,8 +65,7 @@ func Example_RegisterBackendModule() {
 	// Hello, client
 }
 
-const sampleLuaCode = `
-print("lua http test\n")
+const sampleLuaCode = `print("lua http test\n")
 local r = http_response.new(url, "POST", '{"foo":"bar"}', {["foo"] = "bar", ["123"] = "456"})
 print(r:statusCode())
 print(r:headers('Content-Type'))

diff --git a/proxy/proxy_test.go b/proxy/proxy_test.go
@@ -20,14 +20,17 @@ import (
 
 func TestProxyFactory_error(t *testing.T) {
 	testProxyFactoryError(t, `custom_error('expect me')`, "expect me", false, 0)
+	testProxyFactoryPostError(t, `custom_error('expect me')`, "expect me", false, 0)
 }
 
 func TestProxyFactory_errorHTTP(t *testing.T) {
 	testProxyFactoryError(t, `custom_error('expect me', 404)`, "expect me", true, 404)
+	testProxyFactoryPostError(t, `custom_error('expect me', 404)`, "expect me", true, 404)
 }
 
 func TestProxyFactory_errorHTTPJson(t *testing.T) {
 	testProxyFactoryError(t, `custom_error('{"msg":"expect me"}', 404)`, `{"msg":"expect me"}`, true, 404)
+	testProxyFactoryPostError(t, `custom_error('{"msg":"expect me"}', 404)`, `{"msg":"expect me"}`, true, 404)
 }
 
 func testProxyFactoryError(t *testing.T, code, errMsg string, isHTTP bool, statusCode int) {
@@ -106,6 +109,80 @@ func testProxyFactoryError(t *testing.T, code, errMsg string, isHTTP bool, statu
 	}
 }
 
+func testProxyFactoryPostError(t *testing.T, code, errMsg string, isHTTP bool, statusCode int) {
+	buff := bytes.NewBuffer(make([]byte, 1024))
+	logger, err := logging.NewLogger("ERROR", buff, "pref")
+	if err != nil {
+		t.Error("building the logger:", err.Error())
+		return
+	}
+
+	explosive := proxy.FactoryFunc(func(_ *config.EndpointConfig) (proxy.Proxy, error) {
+		return func(_ context.Context, _ *proxy.Request) (*proxy.Response, error) {
+			return &proxy.Response{}, nil
+		}, nil
+	})
+
+	prxy, err := ProxyFactory(logger, explosive).New(&config.EndpointConfig{
+		Endpoint: "/",
+		ExtraConfig: config.ExtraConfig{
+			ProxyNamespace: map[string]interface{}{
+				"post": code,
+			},
+		},
+	})
+
+	if err != nil {
+		t.Error(err)
+	}
+
+	URL, _ := url.Parse("https://some.host.tld/path/to/resource?and=querystring")
+
+	resp, err := prxy(context.Background(), &proxy.Request{
+		Method:  "GET",
+		Path:    "/some-path",
+		Params:  map[string]string{"Id": "42"},
+		Headers: map[string][]string{},
+		URL:     URL,
+		Body:    io.NopCloser(strings.NewReader("initial req content")),
+	})
+
+	if resp != nil {
+		t.Errorf("unexpected response: %v", resp)
+		return
+	}
+
+	if err == nil {
+		t.Error("the script did not return an error")
+		return
+	}
+
+	switch err := err.(type) {
+	case lua.ErrInternalHTTP:
+		if !isHTTP {
+			t.Errorf("unexpected http error: %v (%T)", err, err)
+			return
+		}
+		if sc := err.StatusCode(); sc != statusCode {
+			t.Errorf("unexpected http status code: %d", sc)
+			return
+		}
+	case lua.ErrInternal:
+		if isHTTP {
+			t.Errorf("unexpected internal error: %v (%T)", err, err)
+			return
+		}
+	default:
+		t.Errorf("unexpected error: %v (%T)", err, err)
+		return
+	}
+
+	if e := err.Error(); e != errMsg {
+		t.Errorf("unexpected error. have: '%s', want: '%s' (%T)", e, errMsg, err)
+		return
+	}
+}
+
 func TestProxyFactory(t *testing.T) {
 	buff := bytes.NewBuffer(make([]byte, 1024))
 	logger, err := logging.NewLogger("ERROR", buff, "pref")