Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nonclangable.conf: fix systemd efi build #837

Merged
merged 1 commit into from
Aug 12, 2023
Merged

Conversation

quaresmajose
Copy link
Contributor

@quaresmajose quaresmajose commented Aug 10, 2023

  • systemd-boot have it fixed on recipe but as it a clang issue it's better to move it here
  • systemd needs it when build with efi package config enabled since v254

Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

conf/nonclangable.conf Outdated Show resolved Hide resolved
- systemd-boot have it fixed on recipe but as it a clang issue
it's better to move it here
- systemd needs it when build with efi package config enabled
since v254

Signed-off-by: Jose Quaresma <[email protected]>
@quaresmajose
Copy link
Contributor Author

Don't quite understand the relation of this error with the proposed change on the PR

Test case logrotate.LogrotateTest.test_logrotate_newlog depends on logrotate.LogrotateTest.test_logrotate_wtmp but it didn't pass/run.
Not appropiate for systemd image
Traceback (most recent call last):
  File "/home/khem/actions-runner-meta-clang/_work/meta-clang/meta-clang/yoe/sources/poky/meta/lib/oeqa/core/decorator/__init__.py", line 35, in wrapped_f
    return func(*args, **kwargs)
  File "/home/khem/actions-runner-meta-clang/_work/meta-clang/meta-clang/yoe/sources/poky/meta/lib/oeqa/runtime/cases/parselogs.py", line 393, in test_parselogs
    self.assertEqual(errcount, 0, msg=self.msg)
AssertionError: 1 != 0 : Log: /home/khem/actions-runner-meta-clang/_work/meta-clang/meta-clang/yoe/build/tmp/work/qemuarm64-yoe-linux/yoe-sdk-image/1.0-r0/target_logs/postinstall.log
-----------------------
Central error:  * opkg_cmd_exec: Command failed to capture privilege lock: Resource temporarily unavailable.
***********************
 * opkg_lock: Could not lock /run/opkg.lock: Resource temporarily unavailable.
 * opkg_cmd_exec: Command failed to capture privilege lock: Resource temporarily unavailable.

# otherwise systemd efi fails to build
# error: the 'sse' unit is not supported with this instruction set
TUNE_CCARGS:remove:pn-systemd:toolchain-clang = "-mfpmath=sse"
TUNE_CCARGS:remove:pn-systemd-boot:toolchain-clang = "-mfpmath=sse"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if its should be moved here. It improves the situation, where it reports errors while gcc does not. SSE is not available everywhere and clang rightly points it out. also look at ltp recipe

@kraj kraj merged commit 83c94b8 into kraj:master Aug 12, 2023
1 check passed
@quaresmajose quaresmajose deleted the systemd branch November 10, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants