Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang: Apply upstream D152570 #811

Merged
merged 1 commit into from
Jun 16, 2023
Merged

clang: Apply upstream D152570 #811

merged 1 commit into from
Jun 16, 2023

Conversation

dankm
Copy link
Contributor

@dankm dankm commented Jun 16, 2023

This fixes real file names appearing in lambda names that are used as arguments to function templates.

This fixes llvm/llvm-project#63219, which I spotted when building cmake.


Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

This fixes real file names appearing in lambda names that are
used as arguments to function templates.

Signed-off-by: Dan McGregor <[email protected]>
@dankm dankm requested a review from kraj as a code owner June 16, 2023 16:36
Copy link
Owner

@kraj kraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Can you also request its backport to clang-16 release branch unstream?

@dankm
Copy link
Contributor Author

dankm commented Jun 16, 2023

Sure, I'll probably do that Monday. I'll also request llvm/llvm-project#62192 while at it.

@dankm
Copy link
Contributor Author

dankm commented Jun 16, 2023

Requested a couple backports: llvm/llvm-project#63356

@dankm
Copy link
Contributor Author

dankm commented Jun 16, 2023

@kraj looks like there won't be any backports: https://discourse.llvm.org/t/16-0-6-release/71344

LLVM 16.x is apparently closed, but at least these changes will be in LLVM 17.

@kraj
Copy link
Owner

kraj commented Jun 16, 2023

@kraj looks like there won't be any backports: https://discourse.llvm.org/t/16-0-6-release/71344

LLVM 16.x is apparently closed, but at least these changes will be in LLVM 17.

ok

@kraj kraj merged commit 3d26f0a into kraj:master Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Absolute build paths appear when pretty printing the name of template function with lambda parameter
2 participants