Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layer.conf: remove '-mbranch-protection=standard' globally on aarch64 #1000

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

quaresmajose
Copy link
Contributor

@quaresmajose quaresmajose commented Aug 20, 2024

On aarch64 the handling of runtime exception is broken when build with clang.
There is currently a fix for libcxx on the layer but it is not enough and this same fix needs to be applied globally.

First fix attempt just include libcxx:
#963
#968

Remaining reported issue:
#998


Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

quaresmajose added a commit to quaresmajose/meta-lmp that referenced this pull request Aug 20, 2024
This reverts commit d4ea784.

Proposed upstream kraj/meta-clang#1000

Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose added a commit to quaresmajose/meta-lmp that referenced this pull request Aug 20, 2024
This reverts commit d4ea784.

Proposed upstream kraj/meta-clang#1000

First fix attempt [1] end up reverted [2] because libcxx is not enough.
[1] foundriesio#1481
[2] foundriesio#1500

Signed-off-by: Jose Quaresma <[email protected]>
conf/layer.conf Outdated Show resolved Hide resolved
On aarch64 the handling of runtime exception is broken when build with clang.
There is currently a fix for libcxx on the layer but it is not enough and this
same fix needs to be applied globally.

First fix attempt just include libcxx:
kraj#963
kraj#968

Remaining reported issue:
kraj#998

Signed-off-by: Jose Quaresma <[email protected]>
This reverts commit 96b2f3d.

The is required to be applied globally and not only for libcxx.

Signed-off-by: Jose Quaresma <[email protected]>
Copy link
Owner

@kraj kraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kraj kraj merged commit 9e0ef14 into kraj:master Aug 21, 2024
1 check passed
@quaresmajose quaresmajose deleted the mbranch-protection branch August 21, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants