Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Rails 8.0 to the build matrix, removed Rails 6.0, and locked Zeitwerk to 2.6 for Ruby versions before 3.2 #321

Merged
merged 2 commits into from
Oct 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,11 @@ jobs:
- "3.2"
- "3.3"
rails-version:
- "6.0"
- "6.1"
- "7.0"
- "7.1"
- "7.2"
- "8.0"
- "edge"
include:
- ruby-version: "3.3"
Expand All @@ -30,6 +30,10 @@ jobs:
exclude:
- ruby-version: "3.0"
rails-version: "7.2"
- ruby-version: "3.0"
rails-version: "8.0"
- ruby-version: "3.1"
rails-version: "8.0"
- ruby-version: "3.0"
rails-version: "edge"
- ruby-version: "3.1"
Expand Down
16 changes: 10 additions & 6 deletions Appraisals
Original file line number Diff line number Diff line change
@@ -1,23 +1,27 @@
# frozen_string_literal: true

appraise "rails-6.0" do
gem "railties", "~> 6.0.6"
end

appraise "rails-6.1" do
gem "railties", "~> 6.1.7"
gem "zeitwerk", "~> 2.6.18" # 2.7+ requires Ruby 3.2, and we still support Ruby 3.0
end

appraise "rails-7.0" do
gem "railties", "~> 7.0.8"
gem "zeitwerk", "~> 2.6.18" # 2.7+ requires Ruby 3.2, and we still support Ruby 3.0
end

appraise "rails-7.1" do
gem "railties", "~> 7.1.2"
gem "railties", "~> 7.1.4"
gem "zeitwerk", "~> 2.6.18" # 2.7+ requires Ruby 3.2, and we still support Ruby 3.0
end

appraise "rails-7.2" do
gem "railties", "~> 7.2.0.beta2"
gem "railties", "~> 7.2.1"
gem "zeitwerk", "~> 2.6.18" # 2.7+ requires Ruby 3.2, and we still support Ruby 3.0
end

appraise "rails-8.0" do
gem "railties", "~> 8.0.0.rc1"
end

appraise "rails-edge" do
Expand Down
8 changes: 7 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,16 @@
# Changelog

## Development

Changes:

- Added Ruby on Rails 8.0 to the build matrix, removed Rails 6.0 ([321](https://github.com/kpumuk/meta-tags/pull/321))

## 2.22.1 (September 20, 2024) [☰](https://github.com/kpumuk/meta-tags/compare/v2.22.0...v2.22.1)

Changes:

- Removed `meta-tags.gemspec` and `Rakefile` from the gem package ([312](https://github.com/kpumuk/meta-tags/pull/312)
- Removed `meta-tags.gemspec` and `Rakefile` from the gem package ([312](https://github.com/kpumuk/meta-tags/pull/312))
- Use GitHub actions to build, sign and publish the gem ([314](https://github.com/kpumuk/meta-tags/pull/314), [315](https://github.com/kpumuk/meta-tags/pull/315), [316](https://github.com/kpumuk/meta-tags/pull/316))

## 2.22.0 (July 15, 2024) [☰](https://github.com/kpumuk/meta-tags/compare/v2.21.0...v2.22.0)
Expand Down
12 changes: 6 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ Search Engine Optimization (SEO) plugin for Ruby on Rails applications.

## Ruby on Rails

The MetaTags main branch fully supports Ruby on Rails 6.0+ and is tested against all major Ruby on Rails releases.
The MetaTags main branch fully supports Ruby on Rails 6.1+ and is tested against all major Ruby on Rails releases.

> [!NOTE]
> We no longer support Ruby versions older than 3.0 and Ruby on Rails older than 6.0 since they reached their end of life (see [Ruby](https://endoflife.date/ruby) and [Ruby on Rails](https://endoflife.date/rails)).
> We no longer support Ruby versions older than 3.0 and Ruby on Rails older than 6.1 since they reached their end of life (see [Ruby](https://endoflife.date/ruby) and [Ruby on Rails](https://endoflife.date/rails)).

## Installation

Expand Down Expand Up @@ -245,15 +245,15 @@ In order to update the page title, you can use the following trick. First, set t
MetaTags.configure do |config|
config.title_tag_attributes = {id: "page-title"}
end
````
```

Now in your turbo frame, you can update the title using a turbo stream:

```html
<turbo-frame ...>
<turbo-stream action="update" target="page-title">
<template>My new title</template>
</turbo-stream>
<turbo-stream action="update" target="page-title">
<template>My new title</template>
</turbo-stream>
</turbo-frame>
```

Expand Down
1 change: 1 addition & 0 deletions gemfiles/rails_6.1.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,6 @@ source "https://rubygems.org"

gem "steep", "~> 1.7.1", platform: :mri_32
gem "railties", "~> 6.1.7"
gem "zeitwerk", "~> 2.6.18"

gemspec path: "../"
3 changes: 2 additions & 1 deletion gemfiles/rails_6.1.gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ GEM
tzinfo (2.0.6)
concurrent-ruby (~> 1.0)
unicode-display_width (2.6.0)
zeitwerk (2.7.1)
zeitwerk (2.6.18)

PLATFORMS
arm64-darwin
Expand All @@ -192,6 +192,7 @@ DEPENDENCIES
simplecov (~> 0.22.0)
standard (~> 1.31)
steep (~> 1.7.1)
zeitwerk (~> 2.6.18)

BUNDLED WITH
2.4.19
1 change: 1 addition & 0 deletions gemfiles/rails_7.0.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,6 @@ source "https://rubygems.org"

gem "steep", "~> 1.7.1", platform: :mri_32
gem "railties", "~> 7.0.8"
gem "zeitwerk", "~> 2.6.18"

gemspec path: "../"
3 changes: 2 additions & 1 deletion gemfiles/rails_7.0.gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ GEM
tzinfo (2.0.6)
concurrent-ruby (~> 1.0)
unicode-display_width (2.6.0)
zeitwerk (2.7.1)
zeitwerk (2.6.18)

PLATFORMS
arm64-darwin
Expand All @@ -192,6 +192,7 @@ DEPENDENCIES
simplecov (~> 0.22.0)
standard (~> 1.31)
steep (~> 1.7.1)
zeitwerk (~> 2.6.18)

BUNDLED WITH
2.4.19
3 changes: 2 additions & 1 deletion gemfiles/rails_7.1.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
source "https://rubygems.org"

gem "steep", "~> 1.7.1", platform: :mri_32
gem "railties", "~> 7.1.2"
gem "railties", "~> 7.1.4"
gem "zeitwerk", "~> 2.6.18"

gemspec path: "../"
5 changes: 3 additions & 2 deletions gemfiles/rails_7.1.gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ GEM
concurrent-ruby (~> 1.0)
unicode-display_width (2.6.0)
webrick (1.8.2)
zeitwerk (2.7.1)
zeitwerk (2.6.18)

PLATFORMS
arm64-darwin
Expand All @@ -211,7 +211,7 @@ PLATFORMS
DEPENDENCIES
appraisal (~> 2.5.0)
meta-tags!
railties (~> 7.1.2)
railties (~> 7.1.4)
rake (~> 13.0)
rspec (~> 3.13.0)
rspec-html-matchers (~> 0.10.0)
Expand All @@ -222,6 +222,7 @@ DEPENDENCIES
simplecov (~> 0.22.0)
standard (~> 1.31)
steep (~> 1.7.1)
zeitwerk (~> 2.6.18)

BUNDLED WITH
2.4.19
3 changes: 2 additions & 1 deletion gemfiles/rails_7.2.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
source "https://rubygems.org"

gem "steep", "~> 1.7.1", platform: :mri_32
gem "railties", "~> 7.2.0.beta2"
gem "railties", "~> 7.2.1"
gem "zeitwerk", "~> 2.6.18"

gemspec path: "../"
5 changes: 3 additions & 2 deletions gemfiles/rails_7.2.gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ GEM
unicode-display_width (2.6.0)
useragent (0.16.10)
webrick (1.8.2)
zeitwerk (2.7.1)
zeitwerk (2.6.18)

PLATFORMS
aarch64-linux
Expand All @@ -241,7 +241,7 @@ PLATFORMS
DEPENDENCIES
appraisal (~> 2.5.0)
meta-tags!
railties (~> 7.2.0.beta2)
railties (~> 7.2.1)
rake (~> 13.0)
rspec (~> 3.13.0)
rspec-html-matchers (~> 0.10.0)
Expand All @@ -252,6 +252,7 @@ DEPENDENCIES
simplecov (~> 0.22.0)
standard (~> 1.31)
steep (~> 1.7.1)
zeitwerk (~> 2.6.18)

BUNDLED WITH
2.4.19
8 changes: 8 additions & 0 deletions gemfiles/rails_8.0.gemfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# This file was generated by Appraisal

source "https://rubygems.org"

gem "steep", "~> 1.7.1", platform: :mri_32
gem "railties", "~> 8.0.0.rc1"

gemspec path: "../"
Loading