Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to avoid GHC warnings on building #521

Merged
merged 1 commit into from
Oct 14, 2023

Conversation

mpilgrem
Copy link
Contributor

These changes avoid almost all GHC warnings on building. The one warning I could not work out how to avoid was:

<no location info>: warning: [-Wunused-packages]
    The following packages were specified via -package or -package-id flags,
    but were not needed for compilation:
      - base-4.17.2.0 (exposed by flag -package-id base-4.17.2.0)

@tomjaguarpaw
Copy link
Collaborator

Thanks! I'm not a big fan of making effort to avoid warnings, to be honest, but I'll take most of these. A couple I'd like to undo and rethink.

src/Stan/Hie.hs Outdated Show resolved Hide resolved
@mpilgrem
Copy link
Contributor Author

mpilgrem commented Oct 14, 2023

@tomjaguarpaw, hopefully this now reflects what you were looking for.

@tomjaguarpaw tomjaguarpaw enabled auto-merge (rebase) October 14, 2023 19:40
@tomjaguarpaw
Copy link
Collaborator

Thanks! Set to automerge. Feel free to make to submit the other changes as a follow-up PR. I'll give them some thought.

@tomjaguarpaw tomjaguarpaw merged commit aa72858 into kowainik:main Oct 14, 2023
33 checks passed
@mpilgrem mpilgrem deleted the ghc-warnings branch October 14, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants