snapshot: avoid internal api

koush · Mar 31, 2024 · 0b26f4d · 0b26f4d
1 parent be98083
commit 0b26f4d
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 11 deletions.
diff --git a/plugins/snapshot/package-lock.json b/plugins/snapshot/package-lock.json
diff --git a/plugins/snapshot/package.json b/plugins/snapshot/package.json
@@ -1,6 +1,6 @@
 {
    "name": "@scrypted/snapshot",
-   "version": "0.2.42",
+   "version": "0.2.43",
    "description": "Snapshot Plugin for Scrypted",
    "scripts": {
       "scrypted-setup-project": "scrypted-setup-project",

diff --git a/plugins/snapshot/src/image-reader.ts b/plugins/snapshot/src/image-reader.ts
@@ -1,5 +1,6 @@
 import sdk, { BufferConverter, Image, ImageOptions, MediaObject, MediaObjectOptions, ScryptedDeviceBase, ScryptedMimeTypes } from "@scrypted/sdk";
 import type sharp from 'sharp';
+import type { KernelEnum } from "sharp";
 
 let hasLoadedSharp = false;
 let sharpInstance: typeof sharp;
@@ -8,8 +9,6 @@ export function loadSharp() {
         hasLoadedSharp = true;
         try {
             sharpInstance = require('sharp');
-            // not exposed by sharp but it exists.
-            (sharpInstance.kernel as any).linear = 'linear';
             console.log('sharp loaded');
         }
         catch (e) {
@@ -60,11 +59,8 @@ export class VipsImage implements Image {
             });
         }
         if (options?.resize) {
-            let kernel: string;
+            let kernel: keyof KernelEnum;
             switch (options?.resize.filter) {
-                case 'bilinear':
-                    kernel = 'linear';
-                    break;
                 case 'lanczos':
                     kernel = 'lanczos2';
                     break;
@@ -75,12 +71,12 @@ export class VipsImage implements Image {
                     kernel = 'nearest';
                     break;
                 default:
-                    kernel = 'linear';
+                    kernel = 'cubic';
                     break
             }
             transformed.resize(typeof options.resize.width === 'number' ? Math.floor(options.resize.width) : undefined, typeof options.resize.height === 'number' ? Math.floor(options.resize.height) : undefined, {
                 fit: "cover",
-                kernel: kernel as any,
+                kernel: kernel,
             });
         }