#71 仕事詳細ページの実装 #88
Merged
#71 仕事詳細ページの実装 #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
・JobDetailPage._buildSection => SimpleSection ・JobDetailPage._buildHostTypeChips, JobDetailPage._buildAccessTypeChips => RowChips
| final Iterable<T> allData; | ||
|
|
||
| /// 選択肢をキーにしたデータのラベル | ||
| final Map<T, String> allLable; |
There was a problem hiding this comment.
[タイポ] もしエディタにタイポチェックの機能が入っていなければぜひ入れることをおすすめします！
There was a problem hiding this comment.
ご確認ありがとうございます！
修正しました。
タイポも入っていませんでしたので追加しました！
| return Scaffold( | ||
| appBar: AppBar( | ||
| title: const Text('お手伝い募集'), | ||
| centerTitle: true, |
There was a problem hiding this comment.
中央に配置するなら一括で MaterialApp の appBarTheme でやりたいので、ここは一旦消しましょうか！
There was a problem hiding this comment.
一旦削除しました！
とりあえずテーマは変更していませんが、今回のPRでテーマも変更しますか？
もしくは幾つか画面完成後にデザインをみて決定という形でしょうか？
Comment on lines
52
to
60
| Widget _buildErrorPage(String message) { | ||
| return Center( | ||
| child: Text(message), | ||
| ); | ||
| } | ||
|
|
||
| Widget _buildLoadingPage() { | ||
| return const Center(child: CircularProgressIndicator()); | ||
| } |
There was a problem hiding this comment.
この 2 つはいったん必要な箇所にべたっと書いてもらっていいです！（こういうエラーが起きた場合系の UI はあとで一括でうまくやる方法考えたいです！！うっすら考えておいてもらえたりするとめちゃめちゃ嬉しいです！！）
kosukesaigusa
approved these changes
Jul 29, 2023
There was a problem hiding this comment.
ちょっとリファクタ追加して、Approve しました！！88eba3e
今回もとてもすばらしい実装・PR ありがとうございました！！
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#71
close #71
説明
仕事詳細ページを実装しました。
UI
その他
なし
チェックリスト