[参考] テストの例 #59
Closed
[参考] テストの例 #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosukesaigusa
commented
Jul 20, 2023
| required this.forceUpdateConfigId, | ||
| required this.forceUpdateConfigReference, | ||
| // required this.forceUpdateConfigReference, |
kosukesaigusa
commented
Jul 20, 2023
| @@ -5,9 +5,9 @@ | |||
| part of 'force_update_config.dart'; | |||
|
|
|||
| class ReadForceUpdateConfig { | |||
| const ReadForceUpdateConfig._({ | |||
| const ReadForceUpdateConfig({ | |||
There was a problem hiding this comment.
モックで差し替えたいので公開する通常のコンストラクタに変えた（flutterfire_gen でそのように生成されるように変える予定）
narunblog
force-pushed
the
feature/force-update
branch
from
0f1707e
to
4c40780
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
強制アップデート関係のテストを書くための対応の例を示しました（※ 参考に指定ただければいいので、この PR を feature/force-update にマージする必要はありません）。
いまのところ mottai_flutter_app は cloud_firestore パッケージに依存しない予定（いまの main ブランチはそうなっているので）flutterfire_gen で DocumentReference のフィールドを生成しないようにする対応をします（ほかにも公開する通常のコンストラクタも生成します）。
その変更を main ブランチに入れたら伝えますので、なるんさんの feature/force-update に main に取り込んでタスク（この PR の TODO コメントも含む）を再開していただけたらと思います！