Chat messages pagination #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosukesaigusa
commented
Jul 17, 2023
| @@ -9,14 +9,15 @@ environment: | |||
|
|
|||
| dependencies: | |||
| auto_route: ^7.7.0 | |||
| cloud_firestore: ^4.8.3 | |||
There was a problem hiding this comment.
本当は追加したくなかったけれど、仕方なく。
mottai_flutter_app のチャット機能で最後に読み込んだ QueryDocumentSnapshot を保持する必要があるため。
kosukesaigusa
commented
Jul 17, 2023
Comment on lines
+12
to
+27
| Future<(List<ReadChatMessage>, QueryDocumentSnapshot<ReadChatMessage>?)> | ||
| loadMessagesWithCursor({ | ||
| required String chatRoomId, | ||
| required int limit, | ||
| required QueryDocumentSnapshot<ReadChatMessage>? | ||
| lastReadQueryDocumentSnapshot, | ||
| }) async { | ||
| var query = readChatMessageCollectionReference(chatRoomId: chatRoomId) | ||
| .orderBy('createdAt', descending: true); | ||
| final qds = lastReadQueryDocumentSnapshot; | ||
| if (qds != null) { | ||
| query = query.startAfterDocument(qds); | ||
| } | ||
| final qs = await query.limit(limit).get(); | ||
| final readChatMessages = qs.docs.map((qds) => qds.data()).toList(); | ||
| return (readChatMessages, qs.docs.lastOrNull); |
There was a problem hiding this comment.
チャット機能の実装にあたって必要ならこれをいい感じに書き換えてください！
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
該当なし
説明
コミットメッセージの通り。
UI
UI の変更がある（重要な）場合は、スクリーンショットや画面収録を貼り付けてください。
必要に応じて Before, After の画像を貼り付けるのも有効です。
その他
その他に言及したいことがあれば書いてください。
チェックリスト