#100 use social logins #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r-app into #100_use_social_logins
…r-app into #100_use_social_logins # Conflicts: # packages/firebase_common/lib/src/firestore_documents/_export.dart # packages/firebase_common/lib/src/firestore_documents/user_social_login.dart # packages/firebase_common/lib/src/firestore_documents/user_social_login.flutterfire_gen.dart # packages/mottai_flutter_app/lib/auth/auth.dart # packages/mottai_flutter_app/lib/auth/ui/auth_controller.dart # packages/mottai_flutter_app/lib/router/router.gr.dart
…r-app into #100_use_social_logins
kosukesaigusa
approved these changes
Aug 14, 2023
Comment on lines
+12
to
+15
| /// [UserSocialLogin] を作成する。 | ||
| /// | ||
| /// ログイン済みのソーシャルログインにかかるプロパティのみ `true` とし、それ以外は `false` で作成する。 | ||
| /// 既に [UserSocialLogin] が存在する状態で本処理を実行すると、意図せずにプロパティの値が `false` になるため注意。 |
Comment on lines
118
to
121
| Future<void> updateUserSocialLogin({ | ||
| required SignInMethod signInMethod, | ||
| required String userId, | ||
| required bool shouldLink, |
There was a problem hiding this comment.
これでも全然良いですが、この shoudLink については link の unlink のメソッドを分けのも良さそうだと思いました！
ユーザーは、コントローラーを通じて「リンクしたい」or「リンク解除したい」の操作を選択する方が自然かなと思うためです！
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| 2833900 | Google API Key | 4b5d64b | packages/mottai_flutter_app/ios/dev/GoogleService-Info.plist | View secret |
| 2778948 | Google API Key | 4b5d64b | packages/mottai_flutter_app/ios/prod/GoogleService-Info.plist | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
…r-app into #100_use_social_logins
|
これが表示されたのですが、対応方法がよくわかっておらず。。。 |
haterain0203
commented
Aug 15, 2023
Comment on lines
+137
to
+140
| await _createWorkerAndUserSocialLoginWhenFirstSignIn( | ||
| userCredential: userCredential, | ||
| signInMethod: SignInMethod.line, | ||
| ); |
There was a problem hiding this comment.
LINEでサインインした際に、
_createWorkerAndUserSocialLoginWhenFirstSignIn()
の呼び出しが漏れていたので追加しました。
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
close #100
説明
まだ対応できておらず、現在も対応中の事項
UI
開発用のページを追加
その他
チェックリスト