Adding the possibility to add an array of other layers to compare. #4

kent1D · 2018-03-06T17:27:20Z

The option is compareUrls, maybe should be renamed.

Adding the possibility to add an array of other layers to compare. The option is `compareUrls`, maybe should be renamed.

yohanboniface

Sounds good :)
One suggestion: instead of having a new option, maybe just check the type of the value, and accept either a string or an array of strings.
Also a quick note on the README would be cool :)

* a string (just the URL to a layer) * a simple Array (Url => Name) * an Array of Arrays (Url => Name)

kent1D · 2018-07-09T16:18:08Z

We accept a string (just the Url), a simple Array [URL, Name], an array of Arrays [[URL,Name], [URL2,Name2]] ....

Should fix kosmtik/kosmtik#279

5dd8846

Adding the possibility to add an array of other layers to compare. The option is `compareUrls`, maybe should be renamed.

yohanboniface reviewed Mar 7, 2018

View reviewed changes

Use only one option "compareUrl" which can be :

cddb3b6

* a string (just the URL to a layer) * a simple Array (Url => Name) * an Array of Arrays (Url => Name)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding the possibility to add an array of other layers to compare. #4

Adding the possibility to add an array of other layers to compare. #4

kent1D commented Mar 6, 2018

yohanboniface left a comment

kent1D commented Jul 9, 2018

Adding the possibility to add an array of other layers to compare. #4

Are you sure you want to change the base?

Adding the possibility to add an array of other layers to compare. #4

Conversation

kent1D commented Mar 6, 2018

yohanboniface left a comment

Choose a reason for hiding this comment

kent1D commented Jul 9, 2018