Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add missing dot in Docker build command #103

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

WillScarlettOhara
Copy link

@WillScarlettOhara WillScarlettOhara commented Sep 3, 2024

It wasn't immediately clear to me what was causing the issue. Adding the dot makes it more explicit for beginners. This gives them a simple, ready-to-use command.


This change is Reviewable

@Frenzie
Copy link
Member

Frenzie commented Sep 3, 2024

Does . build all the Docker files in the directory? <custom_docker_file> is intended as a placeholder for the relevant Dockerfile.

@WillScarlettOhara
Copy link
Author

The dot just makes the command work in the current directory. Without it, I had an error like in this example:

docker build -f Dockerfile -t vnckoappimage
ERROR: "docker buildx build" requires exactly 1 argument.
See 'docker buildx build --help'.

Usage:  docker buildx build [OPTIONS] PATH | URL | -

Start a build

Added a few notes related to the difficulties I encountered.
@WillScarlettOhara
Copy link
Author

I've added a few instructions and notes. Keep what you think is useful/relevant. 7e1ce7a

@@ -67,10 +67,45 @@ winpty docker exec -it vncko bash
```
From here, you can edit the frontend code. When you want to see your changes reflected, you can **Restart KOReader** from the emulator KOReader system menu.

### Updated KOReader
Allows you to work with a more recent version of KOReader.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really sure what this means. Shouldn't you simply update the one above if something about it is outdated?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought there might be a reason to work with a 2020 version of KOReader, but maybe I'm wrong. It's not my repo so I'd rather add than replace. It's up to you. I'm just sharing my meager experience of what I ended up with today after following your instructions.
In any case, with the current code, if you only modify the KOReader version for a newer one, without changing the rest of the code, you end up with dependency problems and linux versions that are too old. That's why I used Debian Bullseye and installed these dependencies.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh, now I get it, well, the problem anyway. The latest tag hasn't been updated in a while because it's not done automatically anymore. Maybe it shouldn't even be there at all. The correct current image is koreader/koappimage:0.4.4-20.04.

But all old versions still work on the latest systems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants